bug 1868750: UPSTREAM: <drop>: don't use dynamic tokens for KCM #320
Conversation
be sure to drop this commit/`false` below in 4.7. The cloud credential operator is updating the issuer URL in 4.6 https://github.com/openshift/cloud-credential-operator/blob/8d54516/pkg/operator/oidcdiscoveryendpoint/controller.go#L244-L271 This causes the previously issued to tokens to be invalid. This transition should only happen in 4.6 and the name should be stabl-ish from 4.6 to 4.7, so we can go back to this dynamic client without issues.
openshift-ci-robot
added
the
bugzilla/severity-urgent
|
@deads2k: This pull request references Bugzilla bug 1868750, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
@soltysh indicated it was ok in slack. tagging |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
gcp and fips are failing on https://bugzilla.redhat.com/show_bug.cgi?id=1872282 /override ci/prow/e2e-aws-fips |
|
@deads2k: /override requires a failed status context to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-aws-fips |
|
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-aws-fips, ci/prow/e2e-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-aws-fips |
|
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-aws-fips, ci/prow/e2e-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/k8s-e2e-gcp |
|
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/k8s-e2e-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@deads2k: All pull requests linked via external trackers have merged: openshift/kubernetes#320. Bugzilla bug 1868750 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
be sure to drop this commit/
falsebelow in 4.7. The cloud credential operator is updating the issuer URL in 4.6https://github.com/openshift/cloud-credential-operator/blob/8d54516/pkg/operator/oidcdiscoveryendpoint/controller.go#L244-L271
This causes the previously issued to tokens to be invalid. This transition should only happen in 4.6 and the name should
be stabl-ish from 4.6 to 4.7, so we can go back to this dynamic client without issues.