bug 1888663: wait for oauth-apiserver accessibility #403
Conversation
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
the
approved
deads2k
force-pushed
the
wait-for-oauth
branch
from
2503b22
to
8e9b1a3
Compare
|
Lgtm |
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold cancel this is working as expected. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
deads2k
changed the title
openshift-ci-robot
added
the
bugzilla/severity-high
|
@deads2k: This pull request references Bugzilla bug 1888663, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/cherrypick release-4.6 |
|
@deads2k: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -109,18 +129,18 @@ func (c *openshiftAPIServiceAvailabilityCheck) checkForConnection(context generi | |||
| select { | |||
| case <-time.After(60 * time.Second): | |||
| // if we timeout, always return ok so that we can start from a case where all kube-apiservers are down and the SDN isn't coming up | |||
| utilruntime.HandleError(fmt.Errorf("openshift.io-openshift-apiserver-reachable never reached openshift apiservice")) | |||
| utilruntime.HandleError(fmt.Errorf("%s never reached openshift apiservice", c.Name())) | |||
There was a problem hiding this comment.
nit: rm openshift since c.Name() already contains the service name and the namespace
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deads2k
force-pushed
the
wait-for-oauth
branch
from
8e9b1a3
to
d697ae0
Compare
|
New changes are detected. LGTM label has been removed. |
|
fixed verify, relableing |
|
@deads2k: All pull requests linked via external trackers have merged: Bugzilla bug 1888663 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@deads2k: new pull request created: #410 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This has impacts on z-stream upgrade availability. We added an oauth-apiserver as part of a transition for keycloak and other external authentication providers. This change provides logic for waiting on SDN routability to those pods the same as we did for the openshift-apiserver. We have seen in upgrade logs that there is meaningful time that we have to wait.
/hold
holding so we can see the output in the log showing we made contact with oauth APIs.
/cherrypick release-4.6