Bug 1879607: UPSTREAM: 95252: Kube-proxy: Perf-fix: Shrink INPUT chain #425

tssurya · 2020-10-26T12:28:03Z

What type of PR is this?

What this PR does / why we need it:

In kubernetes#56164, we had split the reject rules for non-ep existing services
into KUBE-EXTERNAL-SERVICES chain in order to avoid calling KUBE-SERVICES
from INPUT. However in kubernetes#74394 KUBE-SERVICES was re-added into INPUT.

As noted in kubernetes#56164, kernel is sensitive to the size of INPUT chain. This
patch refrains from calling the KUBE-SERVICES chain from INPUT and FORWARD,
instead adds the lb reject rule to the KUBE-EXTERNAL-SERVICES chain which will be
called from INPUT and FORWARD.

Special notes for your reviewer:

Conflicts:
pkg/proxy/iptables/proxier.go
Minor conflict due to 1f7ea16

Needs to be backported to oc-4.4

openshift-ci-robot · 2020-10-26T12:28:14Z

@tssurya: This pull request references Bugzilla bug 1879607, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1879607: UPSTREAM 95252: Kube-proxy: Perf-fix: Shrink INPUT chain

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

In kubernetes#56164, we had split the reject rules for non-ep existing services into KUBE-EXTERNAL-SERVICES chain in order to avoid calling KUBE-SERVICES from INPUT. However in kubernetes#74394 KUBE-SERVICES was re-added into INPUT. As noted in kubernetes#56164, kernel is sensitive to the size of INPUT chain. This patch refrains from calling the KUBE-SERVICES chain from INPUT and FORWARD, instead adds the lb reject rule to the KUBE-EXTERNAL-SERVICES chain which will be called from INPUT and FORWARD. Conflicts: pkg/proxy/iptables/proxier.go Minor conflict due to 1f7ea16

danwinship · 2020-10-26T14:16:53Z

/lgtm
though you'll need to look at the failed tests

It looks like other people are doing
/cherry-pick 4.6
for 4.6 backports. I think for 4.5 and 4.4 you should use the older process, where you patch the vendored copy of kubernetes in openshift/origin directly, rather than cherry-picking here first.

openshift-cherrypick-robot · 2020-10-26T14:16:54Z

@danwinship: once the present PR merges, I will cherry-pick it on top of 4.6 in a new PR and assign it to you.

In response to this:

/lgtm
though you'll need to look at the failed tests

It looks like other people are doing
/cherry-pick 4.6
for 4.6 backports. I think for 4.5 and 4.4 you should use the older process, where you patch the vendored copy of kubernetes in openshift/origin directly, rather than cherry-picking here first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-26T14:17:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/proxy/OWNERS~~ [danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tssurya · 2020-10-26T14:21:52Z

/retest

tssurya · 2020-10-26T14:24:39Z

/lgtm
though you'll need to look at the failed tests

ack, looking into them

It looks like other people are doing
/cherry-pick 4.6

+1

for 4.6 backports. I think for 4.5 and 4.4 you should use the older process, where you patch the vendored copy of kubernetes in openshift/origin directly, rather than cherry-picking here first.

wokay, I'll take a look at how others did this and follow the procedure. thanks once again for the quick approval and response/help as usual :)

openshift-bot · 2020-10-26T15:13:55Z

/retest