Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1893972: UPSTREAM: 96144: Skip the sig-storage e2e test as early as possible #451

Merged
merged 1 commit into from Nov 20, 2020
Merged

Bug 1893972: UPSTREAM: 96144: Skip the sig-storage e2e test as early as possible #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/e2e/storage/testsuites/base.go
View file
Open in desktop
Expand Up @@ -149,6 +149,9 @@ func skipUnsupportedTest(driver TestDriver, pattern testpatterns.TestPattern) {
dInfo := driver.GetDriverInfo()
var isSupported bool

// 0. Check with driver specific logic
driver.SkipUnsupportedTest(pattern)

// 1. Check if Whether volType is supported by driver from its interface
switch pattern.VolType {
case testpatterns.InlineVolume:
Expand Down Expand Up @@ -177,9 +180,6 @@ func skipUnsupportedTest(driver TestDriver, pattern testpatterns.TestPattern) {
if pattern.FsType == "ntfs" && !framework.NodeOSDistroIs("windows") {
e2eskipper.Skipf("Distro %s doesn't support ntfs -- skipping", framework.TestContext.NodeOSDistro)
}

// 3. Check with driver specific logic
driver.SkipUnsupportedTest(pattern)
}

// VolumeResource is a generic implementation of TestResource that wil be able to
Expand Down