New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: <drop>: enable TCP_USER_TIMEOUT on client connections #457
Conversation
1b07f04
to
c5fe59b
Compare
/assign @sttts |
/lgtm |
c5fe59b
to
7a3d918
Compare
/retest |
7a3d918
to
fc5cdaf
Compare
it allows the client to detect broken connections to the api server more quickly than the default TCP timeout of 15 minutes. note that it will be replaced by an HTTP ping mechanism in the future releases.
fc5cdaf
to
7009c5a
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold it seems that the roration tests (integration) fail only against that PR - https://search.ci.openshift.org/?search=FAIL%3A+TestCertRotationContinuousRequests&maxAge=48h&context=1&type=bug%2Bjunit&name=&maxMatches=5&maxBytes=20971520&groupBy=job |
/retest |
@p0lyn0mial: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@p0lyn0mial: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
we will carry a patch that allows the clients (Kubelet, KCM, etc.) to detect broken connections to the api server more quickly than the default TCP timeout of 15 minutes.
note: this patch will be dropped in future releases once http2/ping is introduced.
the first commit uses openshift/library-go#926
the second commit was created as follows:
./hack/pin-dependency.sh github.com/openshift/library-go 093ad3cf66000cb994f8c8010da43a71ba147671
followed by./hack/update-vendor.sh