Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restart kubelet on ca bundle change #482

Closed
wants to merge 1 commit into from
Closed

restart kubelet on ca bundle change #482

wants to merge 1 commit into from

Conversation

deads2k
Copy link

@deads2k deads2k commented Dec 9, 2020

/hold

Just a demonstration.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Dec 9, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
rphillips
rphillips reviewed Dec 9, 2020
View reviewed changes
cmd/kubelet/app/patch_restart_on_file_change.go Outdated
wrappedContext, cancel := context.WithCancel(ctx)

files := []string{
"path/to/the/file/that/ryan/says",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/etc/kubernetes/kubelet-ca.crt

@deads2k
Copy link
Author

deads2k commented Dec 9, 2020

This tickled a memory for me of writing and reviewing changes in https://github.com/kubernetes/kubernetes/blob/master/cmd/kubelet/app/auth.go#L68-L102 . I think it's worth seeing if the file is just reloaded with no impact.

@openshift-merge-robot
Copy link

@deads2k: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-commits 9812af9 link /test verify-commits
ci/prow/verify 9812af9 link /test verify
ci/prow/e2e-aws-fips 9812af9 link /test e2e-aws-fips
ci/prow/k8s-e2e-gcp-serial 9812af9 link /test k8s-e2e-gcp-serial
ci/prow/k8s-e2e-gcp 9812af9 link /test k8s-e2e-gcp
ci/prow/e2e-agnostic-cmd 9812af9 link /test e2e-agnostic-cmd
ci/prow/e2e-gcp 9812af9 link /test e2e-gcp
ci/prow/e2e-aws-csi 9812af9 link /test e2e-aws-csi
ci/prow/e2e-aws-serial 9812af9 link /test e2e-aws-serial
ci/prow/e2e-gcp-upgrade 9812af9 link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Author

deads2k commented Dec 10, 2020

yeah, it just auto-reloads. this isn't needed.

@deads2k deads2k closed this Dec 10, 2020
atiratree pushed a commit to atiratree/kubernetes that referenced this pull request May 25, 2021
@k8s-ci-robot
Merge pull request kubernetes#98350 from nilo19/bug/cherry-pick-482
fadf85d 
Cherry pick openshift#482 from cloud provider azure: aggregate errors when putting vmss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphillips rphillips rphillips left review comments

@sjenning sjenning Awaiting requested review from sjenning

@sttts sttts Awaiting requested review from sttts

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deads2k @openshift-ci-robot @openshift-merge-robot @rphillips