adds a unit test for checking if graceful shutdown of HTTP2 server works #483
Conversation
p0lyn0mial
force-pushed
the
graceful-shutdown-unit
branch
from
6f16ae1
to
4ac594b
Compare
|
/test unit |
…f HTTP2 server works
p0lyn0mial
force-pushed
the
graceful-shutdown-unit
branch
from
4ac594b
to
cd10fae
Compare
p0lyn0mial
changed the title
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
TestGracefulShutdownForActiveHTTP2Streamschecks if graceful shut down of HTTP2 server works.It expects that all active connections will be finished (without any errors) before the server exits.
The test sends 25 requests to the target server in parallel. Each request is held by the target server for 60s.
As soon as the target server receives the last request the test calls backendServer.Config.Shutdown which gracefully shuts down the server without interrupting any active connections.
Note this test will fail on upstream golang 1.15
OpenShift carries a patch that makes it to work.
See more at: golang/go#39776
Note:
Tested successfully on
registry.svc.ci.openshift.org/openshift/release:rhel-8-release-golang-1.15-openshift-4.7