Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vendoring of shared libraries missed by 1.20 rebase. #488

Merged
merged 1 commit into from Dec 15, 2020
Merged

Fix vendoring of shared libraries missed by 1.20 rebase. #488

merged 1 commit into from Dec 15, 2020

Conversation

marun
Copy link

@marun marun commented Dec 15, 2020 •
edited

#471 merged with fake bumps. This PR updates to use the vendoring of the shared libraries rather than developer branches.

@openshift-ci-robot openshift-ci-robot added vendor-update Touching vendor dir or related files approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 15, 2020
@marun marun mentioned this pull request Dec 15, 2020
Closed
@marun
Copy link
Author

marun commented Dec 15, 2020

/retest

@soltysh
Copy link
Member

soltysh commented Dec 15, 2020

/override ci/prow/e2e-aws-fips
/override ci/prow/e2e-gcp

The failures are expected and same as the rebase, this PR is helping to clean the dependencies to proper branches from openshift repos.

@openshift-ci-robot
Copy link

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-fips, ci/prow/e2e-gcp

In response to this:

/override ci/prow/e2e-aws-fips
/override ci/prow/e2e-gcp

The failures are expected and same as the rebase, this PR is helping to clean the dependencies to proper branches from openshift repos.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [marun,soltysh,tnozicka]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 87544c5 into openshift:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@sttts sttts Awaiting requested review from sttts

@tnozicka tnozicka Awaiting requested review from tnozicka

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marun @soltysh @openshift-ci-robot @tnozicka @openshift-merge-robot