Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert OWNERS changes #544

Merged
merged 4 commits into from Feb 3, 2021
Merged

Revert OWNERS changes #544

merged 4 commits into from Feb 3, 2021

Conversation

sttts
Copy link

@sttts sttts commented Jan 28, 2021 •
edited

We now us DOWNSTREAM_OWNERS.

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Jan 28, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2021
@sttts
Copy link
Author

sttts commented Jan 28, 2021

/assign @mfojtik @deads2k

@sttts
Copy link
Author

sttts commented Jan 28, 2021

/retest

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jan 29, 2021
@openshift openshift deleted a comment from openshift-ci-robot Jan 29, 2021
@openshift openshift deleted a comment from openshift-ci-robot Jan 29, 2021
@openshift openshift deleted a comment from openshift-ci-robot Jan 29, 2021
@stevekuznetsov
Copy link

/validate-backports

@openshift-ci-robot
Copy link

@stevekuznetsov: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

  • 9f042e2: does not specify an upstream backport in the commit message
  • f9fb6f1: does not specify an upstream backport in the commit message
  • fcd0b42: does not specify an upstream backport in the commit message

@openshift openshift deleted a comment from openshift-ci-robot Jan 29, 2021
@openshift-ci-robot
Copy link

@stevekuznetsov: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

  • 9f042e2: does not specify an upstream backport in the commit message
  • f9fb6f1: does not specify an upstream backport in the commit message
  • fcd0b42: does not specify an upstream backport in the commit message

@openshift-ci-robot
Copy link

@sttts: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

  • 37d90c7dd74330e75a3d696243a5abf5d27cae62: does not specify an upstream backport in the commit message
  • 9f042e2: does not specify an upstream backport in the commit message
  • f9fb6f1: does not specify an upstream backport in the commit message
  • fcd0b42: does not specify an upstream backport in the commit message

@sttts sttts force-pushed the sttts-revert-downstream-approvers branch from 37d90c7 to 6ebc43a Compare January 30, 2021 12:14
@openshift-ci-robot
Copy link

@sttts: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

  • 6ebc43a: does not specify an upstream backport in the commit message
  • 9f042e2: does not specify an upstream backport in the commit message
  • f9fb6f1: does not specify an upstream backport in the commit message
  • fcd0b42: does not specify an upstream backport in the commit message

@sttts
Copy link
Author

sttts commented Feb 1, 2021

/retest

@mfojtik
Copy link
Member

mfojtik commented Feb 1, 2021

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik mfojtik added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 2, 2021
@mfojtik
Copy link
Member

mfojtik commented Feb 2, 2021

adding valid-bug manually, this does not need BZ or cherry-pick approval.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e761892 into openshift:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@mfojtik mfojtik

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sttts @stevekuznetsov @openshift-ci-robot @mfojtik @openshift-bot @deads2k @openshift-merge-robot