Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: enable CSI Migration only on A/D Controller #568

Closed

Conversation

bertinatto
Copy link
Member

This PR is a PoC that enabled CSI Migration only on A/D Controller.

Please don't review yet.

@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 15, 2021
@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@sttts
Copy link

sttts commented Feb 25, 2021

I hold back from reviewing. But please note that this has to go into upstream master before merging.

@bertinatto
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@bertinatto bertinatto changed the base branch from master to release-4.7 March 1, 2021 11:08
@openshift-ci-robot
Copy link

@bertinatto: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP: enable CSI Migration only on A/D Controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto bertinatto changed the base branch from release-4.7 to master March 1, 2021 11:09
@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@bertinatto bertinatto changed the base branch from master to release-4.7 March 1, 2021 13:05
@openshift-ci-robot
Copy link

@bertinatto: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP: enable CSI Migration only on A/D Controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bertinatto
To complete the pull request process, please assign mfojtik after the PR has been reviewed.
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto
Copy link
Member Author

/retest

1 similar comment
@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/test e2e-aws-disruptive

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Mar 5, 2021
@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

@bertinatto bertinatto changed the base branch from release-4.7 to master March 5, 2021 07:25
@openshift-ci
Copy link

openshift-ci bot commented Mar 5, 2021

@bertinatto: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/unit d1177da link /test unit
ci/prow/integration d1177da link /test integration
ci/prow/e2e-vsphere d1177da link /test e2e-vsphere
ci/prow/e2e-agnostic-cmd d1177da link /test e2e-agnostic-cmd
ci/prow/e2e-azure d1177da link /test e2e-azure
ci/prow/e2e-aws d1177da link /test e2e-aws
ci/prow/e2e-aws-ovn d1177da link /test e2e-aws-ovn
ci/prow/e2e-aws-multitenant d1177da link /test e2e-aws-multitenant
ci/prow/e2e-gcp d1177da link /test e2e-gcp
ci/prow/e2e-aws-disruptive d1177da link /test e2e-aws-disruptive
ci/prow/e2e-aws-fips d1177da link /test e2e-aws-fips
ci/prow/e2e-aws-csi d1177da link /test e2e-aws-csi
ci/prow/e2e-metal-ipi-ovn-ipv6 d1177da link /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi d1177da link /test e2e-metal-ipi
ci/prow/e2e-aws-serial d1177da link /test e2e-aws-serial
ci/prow/k8s-e2e-gcp d1177da link /test k8s-e2e-gcp
ci/prow/k8s-e2e-gcp-serial d1177da link /test k8s-e2e-gcp-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bertinatto
Copy link
Member Author

We're not going to take this approach anymore.

@bertinatto bertinatto closed this Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants