Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick gracefulshutdown #617

Closed

Conversation

wgahnagl
Copy link

@wgahnagl wgahnagl commented Mar 15, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

allows pods to gracefully shut down

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Mar 15, 2021
@openshift-ci-robot
Copy link

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wgahnagl
To complete the pull request process, please assign sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 15, 2021
@openshift-ci-robot
Copy link

Hi @wgahnagl. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wgahnagl wgahnagl force-pushed the cherry-pick-gracefulshutdown branch from 6ddfa01 to 7e649e9 Compare March 15, 2021 13:21
@openshift-ci-robot
Copy link

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@wgahnagl wgahnagl changed the title Cherry pick gracefulshutdown WIP: Cherry pick gracefulshutdown Mar 15, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2021
@wgahnagl wgahnagl changed the title WIP: Cherry pick gracefulshutdown WIP Cherry pick gracefulshutdown Mar 15, 2021
@wgahnagl wgahnagl changed the title WIP Cherry pick gracefulshutdown [WIP] Cherry pick gracefulshutdown Mar 15, 2021
@wgahnagl wgahnagl force-pushed the cherry-pick-gracefulshutdown branch from 7e649e9 to bb08b19 Compare March 15, 2021 14:42
@openshift-ci-robot
Copy link

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@wgahnagl wgahnagl force-pushed the cherry-pick-gracefulshutdown branch from bb08b19 to 3b18acb Compare March 15, 2021 14:48
@openshift-ci-robot
Copy link

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@wgahnagl wgahnagl force-pushed the cherry-pick-gracefulshutdown branch from 3b18acb to 3df3fee Compare March 15, 2021 14:52
@openshift-ci-robot
Copy link

@wgahnagl: the contents of this pull request could be automatically validated.

The following commits are valid:

@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Mar 15, 2021
@rphillips
Copy link

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 15, 2021
@wgahnagl wgahnagl changed the title [WIP] Cherry pick gracefulshutdown Cherry pick gracefulshutdown Mar 15, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2021
@wgahnagl
Copy link
Author

/retest

Add a new static pod after checking if its mirror pod is pending termination.
@wgahnagl wgahnagl force-pushed the cherry-pick-gracefulshutdown branch from 3df3fee to d7e0d9b Compare March 17, 2021 20:50
@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. and removed backports/validated-commits Indicates that all commits come to merged upstream PRs. labels Mar 17, 2021
@openshift-ci-robot
Copy link

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci
Copy link

openshift-ci bot commented Mar 24, 2021

@wgahnagl: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-commits d7e0d9b link /test verify-commits
ci/prow/unit d7e0d9b link /test unit
ci/prow/verify d7e0d9b link /test verify
ci/prow/e2e-gcp-upgrade d7e0d9b link /test e2e-gcp-upgrade
ci/prow/e2e-aws-downgrade d7e0d9b link /test e2e-aws-downgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2021

@wgahnagl: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2021
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 12, 2021
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 11, 2021
@wgahnagl wgahnagl closed this Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants