Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1942630: UPSTREAM: 96789: Choosing the right source VIP for local endpoints #639

Merged

Conversation

sebsoto
Copy link

@sebsoto sebsoto commented Mar 24, 2021

This fixes an issue where LoadBalancers would stop directing traffic to Windows pods, when multiple pods were behind the LoadBalancer.

@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 24, 2021
@openshift-ci-robot
Copy link

@sebsoto: This pull request references Bugzilla bug 1942630, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "4.6.0" instead
  • expected dependent Bugzilla bug 1905950 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1942628 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1905950 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1942630: UPSTREAM: 96789: Choosing the right source VIP for local endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@sebsoto: the contents of this pull request could be automatically validated.

The following commits are valid:

@sebsoto
Copy link
Author

sebsoto commented Mar 24, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link

@sebsoto: This pull request references Bugzilla bug 1942630, which is invalid:

  • expected dependent Bugzilla bug 1942628 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp
Copy link

/cc @dcbw @JacobTanenbaum

@sebsoto
Copy link
Author

sebsoto commented Mar 25, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link

@sebsoto: An error was encountered querying GitHub for users with public email (sgao@redhat.com) for bug 1942630 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\",\n \"message\": \"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sebsoto
Copy link
Author

sebsoto commented Mar 25, 2021

/retest

@sebsoto
Copy link
Author

sebsoto commented Mar 25, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 25, 2021
@openshift-ci-robot
Copy link

@sebsoto: This pull request references Bugzilla bug 1942630, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1942628 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1942628 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @sgaoshang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Member

dcbw commented Mar 25, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2021
@sttts
Copy link

sttts commented Mar 25, 2021

/hold

this branch is not intended for kube-proxy.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2021
@sttts
Copy link

sttts commented Mar 25, 2021

As agreed on Slack, WMCO will move away in 4.8 from vendoring the master and release branches of this repository. They are not meant to be consumed by other components and might break at any time for their use-case.

For 4.6, we will accept this carry to keep the builds working.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2021
@sttts
Copy link

sttts commented Mar 25, 2021

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, sebsoto, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
@deads2k
Copy link

deads2k commented Mar 25, 2021

Jira story here: https://issues.redhat.com/browse/WINC-593

@jwforres jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit a5a0987 into openshift:release-4.6 Mar 25, 2021
@openshift-ci-robot
Copy link

@sebsoto: All pull requests linked via external trackers have merged:

Bugzilla bug 1942630 has been moved to the MODIFIED state.

In response to this:

Bug 1942630: UPSTREAM: 96789: Choosing the right source VIP for local endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sebsoto added a commit to sebsoto/windows-machine-config-operator that referenced this pull request Mar 26, 2021
Updates the kubernetes submodule to openshift/kubernetes#639

Done with `git submodule update --remote kubernetes`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants