Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "UPSTREAM: 97295: Fix staticcheck in test/integration/{examples,framework}" #648

Merged
merged 1 commit into from Apr 6, 2021

Conversation

mfojtik
Copy link
Member

@mfojtik mfojtik commented Apr 6, 2021

Reverts #644

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 6, 2021
@openshift-ci-robot
Copy link

@mfojtik: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2021
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2021
@mfojtik mfojtik force-pushed the revert-644-openshift_cherry_pick_97295 branch from 5dfac97 to bac7fd5 Compare April 6, 2021 08:16
@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed lgtm Indicates that a PR is ready to be merged. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Apr 6, 2021
@openshift-ci-robot
Copy link

@mfojtik: the contents of this pull request could be automatically validated.

The following commits are valid:

@sttts
Copy link

sttts commented Apr 6, 2021

/lgtm

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik
Copy link
Member Author

mfojtik commented Apr 6, 2021

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-gcp
/override ci/prow/e2e-gcp-upgrade
/override ci/prow/images
/override ci/prow/integration
/override ci/prow/k8s-e2e-gcp
/override ci/prow/k8s-e2e-gcp-serial
/override ci/prow/unit
/override ci/prow/verify
/override ci/prow/verify-commits

@openshift-ci-robot
Copy link

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws-serial, ci/prow/e2e-gcp, ci/prow/e2e-gcp-upgrade, ci/prow/images, ci/prow/integration, ci/prow/k8s-e2e-gcp, ci/prow/k8s-e2e-gcp-serial, ci/prow/unit, ci/prow/verify, ci/prow/verify-commits

In response to this:

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-gcp
/override ci/prow/e2e-gcp-upgrade
/override ci/prow/images
/override ci/prow/integration
/override ci/prow/k8s-e2e-gcp
/override ci/prow/k8s-e2e-gcp-serial
/override ci/prow/unit
/override ci/prow/verify
/override ci/prow/verify-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member Author

mfojtik commented Apr 6, 2021

/override ci/prow/artifacts
/override ci/prow/e2e-agnostic-cmd
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-fips

@openshift-ci-robot
Copy link

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/artifacts, ci/prow/e2e-agnostic-cmd, ci/prow/e2e-aws-csi, ci/prow/e2e-aws-fips

In response to this:

/override ci/prow/artifacts
/override ci/prow/e2e-agnostic-cmd
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-fips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik merged commit fb7be34 into master Apr 6, 2021
@mfojtik mfojtik deleted the revert-644-openshift_cherry_pick_97295 branch April 6, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants