Bug 1939537: UPSTREAM: 100678: apf: exempt probes /healthz /livez /readyz #658

tkashem · 2021-04-12T18:28:33Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

Add a FlowSchema that exempts the following probes from any user:

/readyz
/livez
/healthz

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

openshift-ci-robot · 2021-04-12T18:28:34Z

@tkashem: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-04-12T18:28:41Z

@tkashem: the contents of this pull request could be automatically validated.

The following commits are valid:

b25c09e|UPSTREAM: 100678: apf: exempt probes /healthz /livez /readyz: the upstream PR kubernetes/kubernetes#100678 has merged

openshift-ci-robot · 2021-04-12T18:57:37Z

@tkashem: This pull request references Bugzilla bug 1939537, which is invalid:

expected dependent Bugzilla bug 1937916 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 1948703 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

deads2k · 2021-04-12T19:20:16Z

/lgtm

openshift-ci-robot · 2021-04-12T19:21:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-04-12T19:58:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-12T21:10:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-13T01:00:50Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-13T01:00:53Z

@openshift-bot: This pull request references Bugzilla bug 1939537, which is invalid:

expected dependent Bugzilla bug 1937916 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-14T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-14T01:01:01Z

@openshift-bot: This pull request references Bugzilla bug 1939537, which is invalid:

expected dependent Bugzilla bug 1937916 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-15T01:00:52Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-15T01:00:56Z

@openshift-bot: This pull request references Bugzilla bug 1939537, which is invalid:

expected dependent Bugzilla bug 1937916 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-16T01:00:12Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-16T01:00:17Z

@openshift-bot: This pull request references Bugzilla bug 1939537, which is invalid:

expected dependent Bugzilla bug 1937916 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-17T01:00:47Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-17T01:00:51Z

@openshift-bot: This pull request references Bugzilla bug 1939537, which is invalid:

expected dependent Bugzilla bug 1937916 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-11-08T01:00:42Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-11-08T01:00:47Z

@openshift-bot: This pull request references Bugzilla bug 1939537, which is invalid:

expected dependent Bugzilla bug 1937916 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-11-09T01:01:11Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-11-09T01:01:15Z

@openshift-bot: This pull request references Bugzilla bug 1939537, which is invalid:

expected dependent Bugzilla bug 1937916 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-11-10T01:01:15Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-11-10T01:01:19Z

@openshift-bot: This pull request references Bugzilla bug 1939537, which is invalid:

expected dependent Bugzilla bug 1937916 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-11-11T01:01:21Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-11-11T01:01:30Z

@openshift-bot: This pull request references Bugzilla bug 1939537, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1937916 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1937916 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wangke19 · 2021-11-11T10:55:48Z

/bugzilla cc-qa

openshift-ci · 2021-11-11T10:55:52Z

@wangke19: This pull request references Bugzilla bug 1939537, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1937916 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1937916 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wangke19 · 2021-11-11T10:56:48Z

Launched one 4.7 cluster with this PR successfully, verification steps see https://bugzilla.redhat.com/show_bug.cgi?id=1939537#c2

wangke19 · 2021-11-11T10:57:31Z

/label qe-approved
/lgtm

openshift-ci · 2021-11-11T10:58:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, tkashem, wangke19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tkashem · 2021-11-11T13:02:55Z

If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.
- verified
- does not apply
The bug has significant impact either through severity, reduction in supportability, or number of users affected.
- verified
- does not apply
For branches that are in the Maintenance lifecycle phase:
- The bug is a critical fix, no reasonable workaround exists, and a recommendation for upgrade has been ruled out, or
- The bug is a security related bug
- Branch not in maintenance mode yet (current release + previous release for 90 days after current GA; everything older is in maintenance)
The severity field of the bug must be set to accurately reflect criticality.
- verified
The PR was created with the cherry-pick bot OR the PR’s description is well formed with user-focused release notes that state the bug number, impact, cause, and resolution. Where appropriate, it should also contain information about how a user can identify whether a particular cluster is affected.
- verified

wangke19 · 2021-11-12T02:50:27Z

@tkashem Need a label backport-risk-assessed

wangke19 · 2021-11-12T02:50:44Z

/label cherry-pick-approved

tkashem · 2021-11-16T12:43:18Z

/label backport-risk-assessed

openshift-bot · 2021-11-16T13:12:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-16T15:22:08Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-16T16:01:20Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-16T17:18:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-11-16T19:14:36Z

@tkashem: All pull requests linked via external trackers have merged:

openshift/kubernetes#658

Bugzilla bug 1939537 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

UPSTREAM: 100678: apf: exempt probes /healthz /livez /readyz

b25c09e

openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. backports/validated-commits Indicates that all commits come to merged upstream PRs. labels Apr 12, 2021

openshift-ci-robot added the vendor-update Touching vendor dir or related files label Apr 12, 2021

openshift-ci-robot requested review from marun and sttts April 12, 2021 18:28

tkashem changed the title ~~UPSTREAM: 100678: apf: exempt probes /healthz /livez /readyz~~ Bug 1939537: UPSTREAM: 100678: apf: exempt probes /healthz /livez /readyz Apr 12, 2021

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 12, 2021

tkashem mentioned this pull request Apr 12, 2021

[release-4.7] bug 1937916: add a flowschema to ensure that probes never get 429s openshift/cluster-kube-apiserver-operator#1083

Closed

openshift-ci-robot assigned deads2k Apr 12, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 11, 2021

openshift-ci bot requested a review from wangke19 November 11, 2021 01:01

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 11, 2021

openshift-ci bot assigned wangke19 Nov 11, 2021

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 12, 2021

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 16, 2021

openshift-merge-robot merged commit 6358137 into openshift:release-4.7 Nov 16, 2021

Bug 1939537: UPSTREAM: 100678: apf: exempt probes /healthz /livez /readyz #658

Bug 1939537: UPSTREAM: 100678: apf: exempt probes /healthz /livez /readyz #658

Conversation

tkashem commented Apr 12, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

openshift-ci-robot commented Apr 12, 2021

openshift-ci-robot commented Apr 12, 2021

openshift-ci-robot commented Apr 12, 2021

deads2k commented Apr 12, 2021

openshift-ci-robot commented Apr 12, 2021

openshift-bot commented Apr 12, 2021

openshift-bot commented Apr 12, 2021

openshift-bot commented Apr 13, 2021

openshift-ci-robot commented Apr 13, 2021

openshift-bot commented Apr 14, 2021

openshift-ci-robot commented Apr 14, 2021

openshift-bot commented Apr 15, 2021

openshift-ci-robot commented Apr 15, 2021

openshift-bot commented Apr 16, 2021

openshift-ci-robot commented Apr 16, 2021

openshift-bot commented Apr 17, 2021

openshift-ci-robot commented Apr 17, 2021

openshift-bot commented Nov 8, 2021

openshift-ci bot commented Nov 8, 2021

openshift-bot commented Nov 9, 2021

openshift-ci bot commented Nov 9, 2021

openshift-bot commented Nov 10, 2021

openshift-ci bot commented Nov 10, 2021

openshift-bot commented Nov 11, 2021

openshift-ci bot commented Nov 11, 2021

wangke19 commented Nov 11, 2021

openshift-ci bot commented Nov 11, 2021

wangke19 commented Nov 11, 2021

wangke19 commented Nov 11, 2021

openshift-ci bot commented Nov 11, 2021

tkashem commented Nov 11, 2021 • edited

wangke19 commented Nov 12, 2021

wangke19 commented Nov 12, 2021

tkashem commented Nov 16, 2021

openshift-bot commented Nov 16, 2021

openshift-bot commented Nov 16, 2021

openshift-bot commented Nov 16, 2021

openshift-bot commented Nov 16, 2021

openshift-ci bot commented Nov 16, 2021

tkashem commented Nov 11, 2021 •

edited