Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Sure we don't run acl audit logging test on OCP-SDN #664

Closed
wants to merge 1 commit into from
Closed

Make Sure we don't run acl audit logging test on OCP-SDN #664

wants to merge 1 commit into from

Conversation

astoycos
Copy link

Following the instructions shown here

Add the test

acl-logging when using one of the plugins 'redhat/openshift-ovs-networkpolicy' should activate acl-logging

To the skipped list for openshift-sdn since it only works
with the OVNKubernetes network-plugin

PR in Origin for new test can be found
here

Signed-off-by: Andrew Stoycos astoycos@redhat.com

Add the test

```
acl-logging when using one of the plugins 'redhat/openshift-ovs-networkpolicy' should activate acl-logging
```
To the skipped list for openshift-sdn since it only works
with the OVNKubernetes network-plugin

PR in Origin for new test can be found
[here](openshift/origin#26071)

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 14, 2021
@openshift-ci-robot
Copy link

@astoycos: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: astoycos
To complete the pull request process, please assign mfojtik after the PR has been reviewed.
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@astoycos
Copy link
Author

/assign @squeed

@openshift-ci
Copy link

openshift-ci bot commented Apr 14, 2021

@astoycos: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-commits edaebc2 link /test verify-commits
ci/prow/verify edaebc2 link /test verify
ci/prow/e2e-aws-csi edaebc2 link /test e2e-aws-csi
ci/prow/e2e-agnostic-cmd edaebc2 link /test e2e-agnostic-cmd
ci/prow/k8s-e2e-gcp edaebc2 link /test k8s-e2e-gcp
ci/prow/e2e-gcp edaebc2 link /test e2e-gcp
ci/prow/e2e-aws-fips edaebc2 link /test e2e-aws-fips
ci/prow/e2e-aws-serial edaebc2 link /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@squeed
Copy link

squeed commented Apr 14, 2021

/hold

I don't think we want this; these rules are only for upstream tests.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2021
@astoycos astoycos closed this Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants