Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: <carry>: generate deprecated api map #679

Closed
wants to merge 2 commits into from

Conversation

sanchezl
Copy link

@sanchezl sanchezl commented Apr 16, 2021

  • Generator for the openshift-kube-apiserver/filters/deprecatedapirequest/deprecated_map.go file.
  • Unit test to detect if file is out-of-sync.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 16, 2021
@openshift-ci-robot
Copy link

@sanchezl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Apr 16, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sanchezl
To complete the pull request process, please assign marun after the PR has been reviewed.
You can assign the PR to them by writing /assign @marun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanchezl sanchezl mentioned this pull request Apr 16, 2021
13 tasks
@openshift-ci
Copy link

openshift-ci bot commented Apr 16, 2021

@sanchezl: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify 0d86f0f link /test verify
ci/prow/e2e-aws-csi 0d86f0f link /test e2e-aws-csi
ci/prow/k8s-e2e-gcp 0d86f0f link /test k8s-e2e-gcp
ci/prow/e2e-aws-serial 0d86f0f link /test e2e-aws-serial
ci/prow/e2e-gcp-upgrade 0d86f0f link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link

deads2k commented Apr 19, 2021

Yeah, this is the generator we want. But I'll have to think about how to snip the dep issue.

{Group: "extensions", Version: "v1beta1", Resource: "networkpolicylist"}: "1.16",
{Group: "extensions", Version: "v1beta1", Resource: "networkpolicys"}: "1.16",
{Group: "extensions", Version: "v1beta1", Resource: "podsecuritypolicylist"}: "1.16",
{Group: "extensions", Version: "v1beta1", Resource: "podsecuritypolicys"}: "1.16",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe

{Group: "extensions", Version: "v1beta1", Resource: "ingresslist"}: "1.22",
{Group: "extensions", Version: "v1beta1", Resource: "networkpolicylist"}: "1.16",
{Group: "extensions", Version: "v1beta1", Resource: "networkpolicys"}: "1.16",
{Group: "extensions", Version: "v1beta1", Resource: "podsecuritypolicylist"}: "1.16",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something went wrong including lists I think.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2021
@openshift-ci
Copy link

openshift-ci bot commented Apr 21, 2021

@sanchezl: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 21, 2021
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 20, 2021
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Sep 19, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2021

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants