Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1951727: Speed up PV provisioning for vsphere driver (ocp-4.6) #691

Merged
merged 1 commit into from Jul 9, 2021
Merged

Bug 1951727: Speed up PV provisioning for vsphere driver (ocp-4.6) #691

merged 1 commit into from Jul 9, 2021

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Apr 20, 2021

@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Apr 20, 2021
@openshift-ci-robot
Copy link

@gnufied: This pull request references Bugzilla bug 1951727, which is invalid:

  • expected dependent Bugzilla bug 1879944 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
  • expected dependent Bugzilla bug 1951726 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
  • expected dependent Bugzilla bug 1879944 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1951727: Speed up PV provisioning for vsphere driver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 20, 2021
@openshift-ci-robot
Copy link

@gnufied: the contents of this pull request could be automatically validated.

The following commits are valid:

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gnufied
To complete the pull request process, please assign marun after the PR has been reviewed.
You can assign the PR to them by writing /assign @marun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gnufied gnufied changed the title Bug 1951727: Speed up PV provisioning for vsphere driver Bug 1951727: Speed up PV provisioning for vsphere driver (ocp-4.6) Apr 20, 2021
@gnufied
Copy link
Member Author

gnufied commented May 25, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 25, 2021
@gnufied
Copy link
Member Author

gnufied commented May 25, 2021

/retest

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 25, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 25, 2021

@gnufied: This pull request references Bugzilla bug 1951727, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1951726 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1951726 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnufied
Copy link
Member Author

gnufied commented May 25, 2021

/assign @soltysh

@gnufied
Copy link
Member Author

gnufied commented May 25, 2021

The unit test failure looks unrelated:


=== Failed
=== FAIL: vendor/k8s.io/kube-aggregator/pkg/apiserver TestProxyCertReload (0.11s)
2021-05-25 14:21:32.882371 I | http: TLS handshake error from 127.0.0.1:39412: tls: failed to verify client certificate: x509: certificate signed by unknown authority
2021-05-25 14:21:32.948930 I | http: TLS handshake error from 127.0.0.1:39416: tls: failed to verify client certificate: x509: certificate has expired or is not yet valid: current time 2021-05-25T14:21:32Z is after 2021-05-22T08:10:51Z
    handler_proxy_test.go:671: Expected status code 200 but got 503

@gnufied
UPSTREAM: 100054: Speed up PV provisioning for vsphere driver
0a0917d 
Speeds up PV provisioning for vSphere driver by
using bulk fetching of hosts and reversing logic that fetches datastores
Add warning about fetching hosts individually
@gnufied gnufied force-pushed the fix-vsphere-slow-provision-46 branch from 60a30b0 to 0a0917d Compare May 26, 2021 14:58
@openshift-ci-robot
Copy link

@gnufied: the contents of this pull request could be automatically validated.

The following commits are valid:

@openshift-ci-robot
Copy link

@gnufied: the contents of this pull request could be automatically validated.

The following commits are valid:

@gnufied
Copy link
Member Author

gnufied commented May 26, 2021

/retest

@gnufied gnufied force-pushed the fix-vsphere-slow-provision-46 branch from 72c60d4 to d81721a Compare May 26, 2021 17:43
@openshift-ci-robot
Copy link

@gnufied: the contents of this pull request could be automatically validated.

The following commits are valid:

@huffmanca
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2021
@deads2k
Copy link

deads2k commented May 26, 2021

have these been backported to kube 1.19?

@gnufied
Copy link
Member Author

gnufied commented May 26, 2021

@deads2k no they have not been backported. Similarly the fix was not backported to 1.20. I can try backporting these.

@gnufied
Copy link
Member Author

gnufied commented May 26, 2021

Opened kubernetes#102351 for 1.19 backport

@ehashman
Copy link

ehashman commented Jun 1, 2021

@gnufied can we backport the cert fix separately? I will open the cherry-picks, ran into the same issue on a diff 4.6 backport.

@gnufied gnufied force-pushed the fix-vsphere-slow-provision-46 branch from d81721a to 0a0917d Compare June 7, 2021 15:15
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2021
@openshift-ci-robot
Copy link

@gnufied: the contents of this pull request could be automatically validated.

The following commits are valid:

@gnufied
Copy link
Member Author

gnufied commented Jun 8, 2021

@ehashman removed btw.

/retest

@deads2k
Copy link

deads2k commented Jun 8, 2021

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2021
@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 6, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@duanwei33
Copy link

/bugzilla cc-qa

@openshift-ci
Copy link

openshift-ci bot commented Jul 8, 2021

@duanwei33: This pull request references Bugzilla bug 1951727, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1951726 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1951726 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@duanwei33
Copy link

duanwei33 commented Jul 8, 2021 •
edited by openshift-ci bot

I'm following JIRA issue DPTP-660 to do the pre-merge verification. Used the cluster-bot launching an env with the still open but Dev-approved PR(s).
The bug is pre-merge verified in 1951727#c2.

@duanwei33
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, duanwei33, gnufied, huffmanca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 8, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4c3480d into openshift:release-4.6 Jul 9, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 9, 2021

@gnufied: All pull requests linked via external trackers have merged:

Bugzilla bug 1951727 has been moved to the MODIFIED state.

In response to this:

Bug 1951727: Speed up PV provisioning for vsphere driver (ocp-4.6)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marun marun Awaiting requested review from marun

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@soltysh soltysh

@huffmanca huffmanca

@duanwei33 duanwei33

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@gnufied @openshift-ci-robot @huffmanca @deads2k @ehashman @openshift-bot @duanwei33 @soltysh @knobunc @openshift-merge-robot