Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1952917: UPSTREAM: 100228: For LoadBalancer Service type don't create a HNS policy for empty or invalid external loadbalancer IP #697

Merged

Conversation

aravindhp
Copy link

No description provided.

…licy for empty or invalid external loadbalancer IP
@openshift-ci-robot
Copy link

@aravindhp: An error was encountered searching for bug 1946628 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. code 102: You are not authorized to access bug #1946628. Most likely the bug has been restricted for internal development processes and we cannot grant access. If you are a Red Hat customer with an active subscription, please visit the Red Hat Customer Portal for assistance with your issue If you are a Fedora Project user and require assistance, please consider using one of the mailing lists we host for the Fedora Project.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1946628: UPSTREAM: 100228: For LoadBalancer Service type don't create a HNS policy for empty or invalid external loadbalancer IP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Apr 21, 2021
@openshift-ci-robot
Copy link

@aravindhp: the contents of this pull request could be automatically validated.

The following commits are valid:

@aravindhp
Copy link
Author

/retitle Bug 1952917: UPSTREAM: 100228: For LoadBalancer Service type don't create a HNS policy for empty or invalid external loadbalancer IP

@openshift-ci-robot openshift-ci-robot changed the title Bug 1946628: UPSTREAM: 100228: For LoadBalancer Service type don't create a HNS policy for empty or invalid external loadbalancer IP Bug 1952917: UPSTREAM: 100228: For LoadBalancer Service type don't create a HNS policy for empty or invalid external loadbalancer IP Apr 23, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 23, 2021
@openshift-ci-robot
Copy link

@aravindhp: This pull request references Bugzilla bug 1952917, which is invalid:

  • expected dependent Bugzilla bug 1952914 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1952917: UPSTREAM: 100228: For LoadBalancer Service type don't create a HNS policy for empty or invalid external loadbalancer IP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp
Copy link
Author

/bugzilla refresh
/retest

@openshift-ci-robot
Copy link

@aravindhp: This pull request references Bugzilla bug 1952917, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1952914 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1952914 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @sgaoshang

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 26, 2021
@aravindhp
Copy link
Author

/cc @dcbw @JacobTanenbaum

@aravindhp
Copy link
Author

/retest

@JacobTanenbaum
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2021
@sttts
Copy link

sttts commented Apr 29, 2021

Upstream merged.

/approve

@sttts
Copy link

sttts commented Apr 29, 2021

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, JacobTanenbaum, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 29, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e3fdce4 into openshift:release-4.7 Apr 30, 2021
@openshift-ci-robot
Copy link

@aravindhp: All pull requests linked via external trackers have merged:

Bugzilla bug 1952917 has been moved to the MODIFIED state.

In response to this:

Bug 1952917: UPSTREAM: 100228: For LoadBalancer Service type don't create a HNS policy for empty or invalid external loadbalancer IP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants