[release-4.7] Bug 1929389: Fix Multi-AZ scheduler e2e tests #757

damemi · 2021-05-20T13:54:21Z

This backports changes from:

This adds a call to createBalancedPods during the ubernetes_lite scheduling e2es, which are prone to improper score balancing due to unbalanced utilization.

…eBalancedPodForNodes

openshift-ci · 2021-05-20T13:54:26Z

@damemi: This pull request references Bugzilla bug 1929389, which is invalid:

expected the bug to target the "4.7.z" release, but it targets "4.8.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
expected Bugzilla bug 1929389 to depend on a bug targeting a release in 4.8.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-05-20T13:54:30Z

@damemi: the contents of this pull request could be automatically validated.

The following commits are valid:

c430709|UPSTREAM: 98699: Balance nodes in scheduling e2e: the upstream PR kubernetes/kubernetes#98699 has merged
d6efd3c|UPSTREAM: 98073: (e2e/scheduler) Ensure minimum memory limit in createBalancedPodForNodes: the upstream PR kubernetes/kubernetes#98073 has merged

damemi

/cc @soltysh
please take a look, these are still flaking in 4.7 but the changes seemed to work for 4.8

As per mdame, we can't ensure that the cluster is actually balanced if other tests are adding or deleting pods in parallel.

openshift-ci-robot · 2021-05-20T14:00:32Z

@damemi: the contents of this pull request could not be automatically validated.

The following commits are valid:

97a2dd1|UPSTREAM: 100378: Tag Multi-AZ scheduling tests as serial: the upstream PR kubernetes/kubernetes#100378 has merged
c430709|UPSTREAM: 98699: Balance nodes in scheduling e2e: the upstream PR kubernetes/kubernetes#98699 has merged
d6efd3c|UPSTREAM: 98073: (e2e/scheduler) Ensure minimum memory limit in createBalancedPodForNodes: the upstream PR kubernetes/kubernetes#98073 has merged

The following commits could not be validated and must be approved by a top-level approver:

0a4982a|UPSTREAM: : Update test annotations: does not specify an upstream backport in the commit message
bc35fda|UPSTREAM: : Stop skipping multi-az test (skipped upstream): does not specify an upstream backport in the commit message

openshift-ci · 2021-05-20T14:05:55Z

@damemi: This pull request references Bugzilla bug 1929389, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
expected dependent Bugzilla bug 1896558 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

damemi · 2021-05-21T12:31:48Z

/retest

damemi · 2021-05-25T15:50:57Z

/retest

soltysh

/lgtm
/approve
/bugzilla refresh

openshift-ci · 2021-05-27T19:06:07Z

@soltysh: This pull request references Bugzilla bug 1929389, which is invalid:

expected dependent Bugzilla bug 1896558 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh · 2021-05-27T19:06:55Z

@damemi all tagged, you need to get the BZ dance correct and cherry-pic approval still

openshift-bot · 2021-05-28T01:00:48Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-28T01:00:51Z

@openshift-bot: This pull request references Bugzilla bug 1929389, which is invalid:

expected dependent Bugzilla bug 1896558 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-29T01:00:39Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-08T01:01:29Z

@openshift-bot: This pull request references Bugzilla bug 1929389, which is invalid:

expected dependent Bugzilla bug 1896558 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 1896558 to target a release in 4.8.0, 4.8.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-09T01:00:31Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-09T01:00:35Z

@openshift-bot: This pull request references Bugzilla bug 1929389, which is invalid:

expected dependent Bugzilla bug 1896558 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 1896558 to target a release in 4.8.0, 4.8.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-10T01:01:15Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-10T01:01:27Z

@openshift-bot: This pull request references Bugzilla bug 1929389, which is invalid:

expected dependent Bugzilla bug 1896558 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 1896558 to target a release in 4.8.0, 4.8.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-11T01:01:16Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-11T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 1929389, which is invalid:

expected dependent Bugzilla bug 1896558 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 1896558 to target a release in 4.8.0, 4.8.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-12T01:01:00Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-12T01:01:05Z

@openshift-bot: This pull request references Bugzilla bug 1929389, which is invalid:

expected dependent Bugzilla bug 1896558 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 1896558 to target a release in 4.8.0, 4.8.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-13T01:01:00Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-13T01:01:04Z

@openshift-bot: This pull request references Bugzilla bug 1929389, which is invalid:

expected dependent Bugzilla bug 1896558 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 1896558 to target a release in 4.8.0, 4.8.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-14T01:00:39Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-14T01:00:44Z

@openshift-bot: This pull request references Bugzilla bug 1929389, which is invalid:

expected dependent Bugzilla bug 1896558 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 1896558 to target a release in 4.8.0, 4.8.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-15T01:01:09Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-15T01:01:14Z

@openshift-bot: This pull request references Bugzilla bug 1929389, which is invalid:

expected dependent Bugzilla bug 1896558 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 1896558 to target a release in 4.8.0, 4.8.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-16T01:00:30Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-16T01:00:36Z

@openshift-bot: This pull request references Bugzilla bug 1929389, which is invalid:

expected dependent Bugzilla bug 1896558 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 1896558 to target a release in 4.8.0, 4.8.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-17T01:01:17Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-17T01:01:21Z

@openshift-bot: This pull request references Bugzilla bug 1929389, which is invalid:

expected dependent Bugzilla bug 1896558 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 1896558 to target a release in 4.8.0, 4.8.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-17T12:38:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-09-17T12:39:31Z

@damemi: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-12-16T16:16:20Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2022-01-15T16:32:00Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2022-02-14T16:58:53Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2022-02-14T16:59:26Z

@openshift-bot: Closed this PR.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

damemi added 2 commits May 20, 2021 09:52

UPSTREAM: 98699: Balance nodes in scheduling e2e

c430709

This adds a call to createBalancedPods during the ubernetes_lite scheduling e2es, which are prone to improper score balancing due to unbalanced utilization.

UPSTREAM: 98073: (e2e/scheduler) Ensure minimum memory limit in creat…

d6efd3c

…eBalancedPodForNodes

openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label May 20, 2021

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 20, 2021

damemi commented May 20, 2021

View reviewed changes

openshift-ci bot requested review from soltysh and mfojtik May 20, 2021 13:54

marun added 3 commits May 20, 2021 10:00

UPSTREAM: 100378: Tag Multi-AZ scheduling tests as serial

97a2dd1

As per mdame, we can't ensure that the cluster is actually balanced if other tests are adding or deleting pods in parallel.

UPSTREAM: <carry>: Stop skipping multi-az test (skipped upstream)

bc35fda

UPSTREAM: <drop>: Update test annotations

0a4982a

openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. and removed backports/validated-commits Indicates that all commits come to merged upstream PRs. labels May 20, 2021

damemi changed the title ~~Bug 1929389: Fix Multi-AZ scheduler e2e tests~~ [release-4.7] Bug 1929389: Fix Multi-AZ scheduler e2e tests May 20, 2021

soltysh approved these changes May 27, 2021

View reviewed changes

openshift-ci bot assigned soltysh May 27, 2021

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 27, 2021

soltysh removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 27, 2021

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2021

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2021

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 15, 2022

openshift-ci bot closed this Feb 14, 2022

[release-4.7] Bug 1929389: Fix Multi-AZ scheduler e2e tests #757

[release-4.7] Bug 1929389: Fix Multi-AZ scheduler e2e tests #757

Conversation

damemi commented May 20, 2021 • edited

openshift-ci bot commented May 20, 2021

openshift-ci-robot commented May 20, 2021

damemi left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented May 20, 2021

openshift-ci bot commented May 20, 2021

damemi commented May 21, 2021

damemi commented May 25, 2021

soltysh left a comment

Choose a reason for hiding this comment

openshift-ci bot commented May 27, 2021

soltysh commented May 27, 2021

openshift-bot commented May 28, 2021

openshift-ci bot commented May 28, 2021

openshift-bot commented May 29, 2021

openshift-ci bot commented Sep 8, 2021

openshift-bot commented Sep 9, 2021

openshift-ci bot commented Sep 9, 2021

openshift-bot commented Sep 10, 2021

openshift-ci bot commented Sep 10, 2021

openshift-bot commented Sep 11, 2021

openshift-ci bot commented Sep 11, 2021

openshift-bot commented Sep 12, 2021

openshift-ci bot commented Sep 12, 2021

openshift-bot commented Sep 13, 2021

openshift-ci bot commented Sep 13, 2021

openshift-bot commented Sep 14, 2021

openshift-ci bot commented Sep 14, 2021

openshift-bot commented Sep 15, 2021

openshift-ci bot commented Sep 15, 2021

openshift-bot commented Sep 16, 2021

openshift-ci bot commented Sep 16, 2021

openshift-bot commented Sep 17, 2021

openshift-ci bot commented Sep 17, 2021

openshift-bot commented Sep 17, 2021

openshift-ci bot commented Sep 17, 2021

openshift-bot commented Dec 16, 2021

openshift-bot commented Jan 15, 2022

openshift-bot commented Feb 14, 2022

openshift-ci bot commented Feb 14, 2022

damemi commented May 20, 2021 •

edited