Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1963263: UPSTREAM: 102000: Ref counting is only applicable to Remote endpoints #763

Merged
merged 1 commit into from May 27, 2021
Merged

Bug 1963263: UPSTREAM: 102000: Ref counting is only applicable to Remote endpoints #763

merged 1 commit into from May 27, 2021

Conversation

aravindhp
Copy link

@aravindhp aravindhp commented May 21, 2021 •
edited

Backport of #762

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 21, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 21, 2021

@aravindhp: This pull request references Bugzilla bug 1963263, which is invalid:

  • expected dependent Bugzilla bug 1939968 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1963263: 102000: Ref counting is only applicable to Remote endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 21, 2021
@openshift-ci-robot
Copy link

@aravindhp: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci openshift-ci bot requested review from deads2k and marun May 21, 2021 21:47
@openshift-ci-robot
Copy link

@aravindhp: the contents of this pull request could be automatically validated.

The following commits are valid:

@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels May 21, 2021
@aravindhp
Copy link
Author

/retitle Bug 1963263: UPSTREAM: 102000: Ref counting is only applicable to Remote endpoints

@openshift-ci openshift-ci bot changed the title Bug 1963263: 102000: Ref counting is only applicable to Remote endpoints Bug 1963263: UPSTREAM: 102000: Ref counting is only applicable to Remote endpoints May 21, 2021
@aravindhp
Copy link
Author

/retest

3 similar comments
@aravindhp
Copy link
Author

/retest

@aravindhp
Copy link
Author

/retest

@mansikulkarni96
Copy link
Member

/retest

@aravindhp
Copy link
Author

aravindhp commented May 24, 2021 •
edited

openshift-metal3/dev-scripts#1242 and openshift/machine-config-operator#2580 needs to merge for the metal-ipi tests to pass

@aravindhp
Copy link
Author

aravindhp commented May 25, 2021 •
edited

For fixing the failing metal-ipi-* tests, according to @stbenjam:

We either need to backport openshift/origin#25994 and openshift/origin#26007 to 4.7 (and likely 4.6, too) or don't specify the provider on < 4.8

Tracked by BZ 1964203

@aravindhp
Copy link
Author

/retest

1 similar comment
@aravindhp
Copy link
Author

/retest

@aravindhp
Copy link
Author

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2021

@aravindhp: This pull request references Bugzilla bug 1963263, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1939968 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1939968 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @sgaoshang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 26, 2021
@openshift-ci openshift-ci bot requested a review from sgaoshang May 26, 2021 15:40
@openshift-ci
Copy link

openshift-ci bot commented May 26, 2021

@aravindhp: This pull request references Bugzilla bug 1963263, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1939968 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1939968 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @sgaoshang

In response to this:

Bug 1963263: UPSTREAM: 102000: Ref counting is only applicable to Remote endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp
Copy link
Author

Waiting on @soltysh wrt #772

soltysh
soltysh approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented May 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2021
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit a0b09eb into openshift:release-4.7 May 27, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 27, 2021

@aravindhp: All pull requests linked via external trackers have merged:

Bugzilla bug 1963263 has been moved to the MODIFIED state.

In response to this:

Bug 1963263: UPSTREAM: 102000: Ref counting is only applicable to Remote endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp aravindhp mentioned this pull request May 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@marun marun Awaiting requested review from marun

@sgaoshang sgaoshang Awaiting requested review from sgaoshang

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@aravindhp @openshift-ci-robot @mansikulkarni96 @soltysh @sdodson @openshift-merge-robot @sbangari