New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1969626: UPSTREAM: 102587: kubelet: Revert "Cleanup portforward streams after their usage" #796
Conversation
…their usage" This reverts commit b14bd44. A regression has been introduced with this patch. The strategy is to apply the fix on master and revert on the release branches.
@ehashman: This pull request references Bugzilla bug 1969626, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ehashman: the contents of this pull request could be automatically validated. The following commits are valid: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, saschagrunert, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test k8s-e2e-gcp |
/test e2e-gcp |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/test e2e-gcp-upgrade |
/retest Please review the full test history for this PR and help us cut down flakes. |
@ehashman: All pull requests linked via external trackers have merged: Bugzilla bug 1969626 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This reverts commit b14bd44.
A regression has been introduced with this patch. The strategy is to
apply the fix on master and revert on the release branches.
BZ https://bugzilla.redhat.com/show_bug.cgi?id=1969626
/cc @rphillips @mrunalp @saschagrunert