Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1969626: UPSTREAM: 102587: kubelet: Revert "Cleanup portforward streams after their usage" #796

Merged
merged 1 commit into from Jun 10, 2021

Conversation

ehashman
Copy link

@ehashman ehashman commented Jun 8, 2021

This reverts commit b14bd44.

A regression has been introduced with this patch. The strategy is to
apply the fix on master and revert on the release branches.

BZ https://bugzilla.redhat.com/show_bug.cgi?id=1969626

/cc @rphillips @mrunalp @saschagrunert

…their usage"

This reverts commit b14bd44.

A regression has been introduced with this patch. The strategy is to
apply the fix on master and revert on the release branches.
@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Jun 8, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jun 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

@ehashman: This pull request references Bugzilla bug 1969626, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to this:

Bug 1969626: UPSTREAM: 102587: kubelet: Revert "Cleanup portforward streams after their usage"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 8, 2021
@openshift-ci-robot
Copy link

@ehashman: the contents of this pull request could be automatically validated.

The following commits are valid:

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jun 8, 2021
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sttts
Copy link

sttts commented Jun 8, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, saschagrunert, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2021
@ehashman
Copy link
Author

ehashman commented Jun 8, 2021

/test k8s-e2e-gcp

@ehashman
Copy link
Author

ehashman commented Jun 8, 2021

/test e2e-gcp

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@ehashman
Copy link
Author

ehashman commented Jun 9, 2021

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@ehashman
Copy link
Author

ehashman commented Jun 9, 2021

/test e2e-gcp-upgrade

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 57ac64a into openshift:master Jun 10, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 10, 2021

@ehashman: All pull requests linked via external trackers have merged:

Bugzilla bug 1969626 has been moved to the MODIFIED state.

In response to this:

Bug 1969626: UPSTREAM: 102587: kubelet: Revert "Cleanup portforward streams after their usage"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants