Wip: shutdown probes before killing pod

[wgahnagl]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[openshift-ci-robot]

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 2383513|adds probe shutdown before pods are killed: does not specify an upstream backport in the commit message

[openshift-ci-robot]

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 8648f45|adds probe shutdown before pods are killed: does not specify an upstream backport in the commit message

[openshift-ci-robot]

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• edae10a|adds probe shutdown before pods are killed: does not specify an upstream backport in the commit message

[openshift-ci-robot]

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• ac5cde0|adds probe shutdown before pods are killed: does not specify an upstream backport in the commit message

[openshift-ci-robot]

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 431c99b|adds probe shutdown before pods are killed: does not specify an upstream backport in the commit message

[wgahnagl]

/retest

[openshift-ci-robot]

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 431c99b|adds probe shutdown before pods are killed: does not specify an upstream backport in the commit message
• ca184c2|adds comment to check for: does not specify an upstream backport in the commit message

[wgahnagl]

/retest

[openshift-ci-robot]

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 85328be|adds probe shutdown before pods are killed: does not specify an upstream backport in the commit message
• dd39b03|adds comment to check for: does not specify an upstream backport in the commit message

[openshift-ci-robot]

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 85328be|adds probe shutdown before pods are killed: does not specify an upstream backport in the commit message
• dd39b03|adds comment to check for: does not specify an upstream backport in the commit message

[openshift-ci-robot]

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 1f176a8|Regenerate KubeletConfiguration: does not specify an upstream backport in the commit message
• 33c7c02|adds probe shutdown before pods are killed: does not specify an upstream backport in the commit message
• 3e5a030|Add e2e: does not specify an upstream backport in the commit message
• 48377e6|Add e2e: does not specify an upstream backport in the commit message
• 58bced5|Add field for KubeletConfiguration: does not specify an upstream backport in the commit message
• 6b9c883|Regenerate violation_exceptions.list: does not specify an upstream backport in the commit message
• d78a414|Implement graceful shutdown based on Pod priority: does not specify an upstream backport in the commit message
• df09916|Add FeatureGate PodPriorityBasedGracefulShutdown: does not specify an upstream backport in the commit message
• f08a8f0|Update unit test: does not specify an upstream backport in the commit message

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wgahnagl
To complete the pull request process, please assign marun after the PR has been reviewed.
You can assign the PR to them by writing /assign @marun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 0301632|Update unit test: does not specify an upstream backport in the commit message
• 33c7c02|adds probe shutdown before pods are killed: does not specify an upstream backport in the commit message
• 35fdc55|Implement graceful shutdown based on Pod priority: does not specify an upstream backport in the commit message
• 5bf513c|Add field for KubeletConfiguration: does not specify an upstream backport in the commit message
• 5cba2a6|Add FeatureGate PodPriorityBasedGracefulShutdown: does not specify an upstream backport in the commit message
• 63ac5b6|Regenerate violation_exceptions.list: does not specify an upstream backport in the commit message
• 7cb3414|Update describe for e2e cases: does not specify an upstream backport in the commit message
• 810e1bc|Add e2e: does not specify an upstream backport in the commit message
• efc0390|Regenerate KubeletConfiguration: does not specify an upstream backport in the commit message

[openshift-ci-robot]

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 0301632|Update unit test: does not specify an upstream backport in the commit message
• 33c7c02|adds probe shutdown before pods are killed: does not specify an upstream backport in the commit message
• 35fdc55|Implement graceful shutdown based on Pod priority: does not specify an upstream backport in the commit message
• 5bf513c|Add field for KubeletConfiguration: does not specify an upstream backport in the commit message
• 5cba2a6|Add FeatureGate PodPriorityBasedGracefulShutdown: does not specify an upstream backport in the commit message
• 63ac5b6|Regenerate violation_exceptions.list: does not specify an upstream backport in the commit message
• 7cb3414|Update describe for e2e cases: does not specify an upstream backport in the commit message
• 810e1bc|Add e2e: does not specify an upstream backport in the commit message
• efc0390|Regenerate KubeletConfiguration: does not specify an upstream backport in the commit message

[openshift-ci-robot]

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 1cffd7c|Add e2e: does not specify an upstream backport in the commit message
• 2e10bd1|Update describe for e2e cases: does not specify an upstream backport in the commit message
• 53f7ce3|Update unit test: does not specify an upstream backport in the commit message
• 6250031|Add field for KubeletConfiguration: does not specify an upstream backport in the commit message
• 7d331fa|sets graceful shutdown to true: does not specify an upstream backport in the commit message
• 999b30f|adds probe shutdown before pods are killed: does not specify an upstream backport in the commit message
• 9f0aa51|Regenerate violation_exceptions.list: does not specify an upstream backport in the commit message
• ade7ee6|Implement graceful shutdown based on Pod priority: does not specify an upstream backport in the commit message
• cf07d56|Add FeatureGate PodPriorityBasedGracefulShutdown: does not specify an upstream backport in the commit message
• f1ab23b|Regenerate KubeletConfiguration: does not specify an upstream backport in the commit message

[openshift-ci-robot]

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 1cffd7c|Add e2e: does not specify an upstream backport in the commit message
• 2e10bd1|Update describe for e2e cases: does not specify an upstream backport in the commit message
• 3e341d4|adds test: does not specify an upstream backport in the commit message
• 53f7ce3|Update unit test: does not specify an upstream backport in the commit message
• 6250031|Add field for KubeletConfiguration: does not specify an upstream backport in the commit message
• 7d331fa|sets graceful shutdown to true: does not specify an upstream backport in the commit message
• 999b30f|adds probe shutdown before pods are killed: does not specify an upstream backport in the commit message
• 9f0aa51|Regenerate violation_exceptions.list: does not specify an upstream backport in the commit message
• ade7ee6|Implement graceful shutdown based on Pod priority: does not specify an upstream backport in the commit message
• cf07d56|Add FeatureGate PodPriorityBasedGracefulShutdown: does not specify an upstream backport in the commit message
• f1ab23b|Regenerate KubeletConfiguration: does not specify an upstream backport in the commit message

[openshift-ci-robot]

@wgahnagl: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 0d31320|Add log for creating node shutdown manager: does not specify an upstream backport in the commit message
• 193f90a|Update describe for e2e cases: does not specify an upstream backport in the commit message
• 1d922ed|Refactor to use structure to pass parameters: does not specify an upstream backport in the commit message
• 1ef34ee|Add exception configuration handling for migrateConfig: does not specify an upstream backport in the commit message
• 22b796d|Add test for validation: does not specify an upstream backport in the commit message
• 2482f28|Regenerate violation_exceptions.list: does not specify an upstream backport in the commit message
• 2f15b46|Add field for KubeletConfiguration: does not specify an upstream backport in the commit message
• 6518ee2|Refactored to use the interface to return to Manager: does not specify an upstream backport in the commit message
• 78b7733|Add FeatureGate PodPriorityBasedGracefulShutdown: does not specify an upstream backport in the commit message
• 7f360b7|Implement graceful shutdown based on Pod priority: does not specify an upstream backport in the commit message
• 83cc232|adds patch: does not specify an upstream backport in the commit message
• 886e5a7|adds probe shutdown before pods are killed: does not specify an upstream backport in the commit message
• 962295f|Add e2e: does not specify an upstream backport in the commit message
• b1cbca5|Update unit test: does not specify an upstream backport in the commit message
• c786c8d|Regenerate KubeletConfiguration: does not specify an upstream backport in the commit message
• d4263e5|Add validation for PodPriorityBasedGracefulShutdown: does not specify an upstream backport in the commit message
• d9e3204|sets graceful shutdown to true: does not specify an upstream backport in the commit message

[openshift-ci]

@wgahnagl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/verify-commits	83cc232	link	/test verify-commits
ci/prow/unit	83cc232	link	/test unit
ci/prow/verify	83cc232	link	/test verify
ci/prow/k8s-e2e-gcp	83cc232	link	/test k8s-e2e-gcp
ci/prow/e2e-gcp-upgrade	83cc232	link	/test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-ci]

@wgahnagl: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.