Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1975553: only chown if non-windows machine with projected volumes #826

Merged
merged 1 commit into from Jun 30, 2021
Merged

[release-4.7] Bug 1975553: only chown if non-windows machine with projected volumes #826

merged 1 commit into from Jun 30, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #804

/assign aravindhp

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 23, 2021
Merged
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 23, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2021

@openshift-cherrypick-robot: Bugzilla bug 1971745 has been cloned as Bugzilla bug 1975553. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1975553: only chown if non-windows machine with projected volumes

In response to this:

[release-4.7] Bug 1971745: only chown if non-windows machine with projected volumes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] Bug 1971745: only chown if non-windows machine with projected volumes [release-4.7] Bug 1975553: only chown if non-windows machine with projected volumes Jun 23, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 23, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1975553, which is invalid:

  • expected dependent Bugzilla bug 1971745 to target a release in 4.8.0, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1975553: only chown if non-windows machine with projected volumes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from marun and mfojtik June 23, 2021 22:07
@aravindhp
Copy link

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2021

@aravindhp: This pull request references Bugzilla bug 1975553, which is invalid:

  • expected dependent Bugzilla bug 1973580 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrunalp mrunalp added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Jun 23, 2021
@mrunalp
Copy link
Member

mrunalp commented Jun 23, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mrunalp, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2021

@openshift-bot: This pull request references Bugzilla bug 1975553, which is invalid:

  • expected dependent Bugzilla bug 1973580 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@aravindhp
Copy link

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@aravindhp
Copy link

/hold

until openshift/installer#5025 merges which is needed for e2e-vsphere to pass.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2021
@aravindhp
Copy link

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Jun 25, 2021

@aravindhp: This pull request references Bugzilla bug 1975553, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1973580 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1973580 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @sgaoshang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 25, 2021
@openshift-ci openshift-ci bot requested a review from sgaoshang June 25, 2021 17:41
@aravindhp
Copy link

/retest

@aravindhp
Copy link

/hold cancel
/retest

openshift/installer#5025 has merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2021
@aravindhp
Copy link

aravindhp commented Jun 28, 2021 •
edited

This PR is needed to release WMCO 2.0.2 which is a requirement for the WMCO 3.0.0 release, to prevent Windows Pods from not coming up after an upgrade from 4.7 to 4.8.

@dhellmann dhellmann added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit d0b1ad4 into openshift:release-4.7 Jun 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1975553 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1975553: only chown if non-windows machine with projected volumes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Jul 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marun marun Awaiting requested review from marun

@mfojtik mfojtik Awaiting requested review from mfojtik

@sgaoshang sgaoshang Awaiting requested review from sgaoshang

Assignees

@mrunalp mrunalp

@aravindhp aravindhp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @aravindhp @mrunalp @openshift-bot @dhellmann @openshift-merge-robot @rphillips