Bug 1982868: UPSTREAM <carry>: ManagementCPUsOverride: Add defaults for missing infrastructure topologies #859
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
openshift-ci
bot
added
bugzilla/severity-medium
|
@wking: This pull request references Bugzilla bug 1982868, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
force-pushed
the
default-topology-for-rollbacks
branch
from
774ed37
to
f0b0565
Compare
|
@wking: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
…frastructure topologies Avoid blocking changes like [1]: deployment openshift-etcd-operator/etcd-operator has a replica failure FailedCreate: pods "etcd-operator-7b677856dc-" is forbidden: autoscaling.openshift.io/ManagementCPUsOverride infrastructure resource has empty status.controlPlaneTopology or status.infrastructureTopology when running against 4.7 versions of the Infrastructure CRD, which lack 4.8's topology properties. 4.8 and later CRDs will have the HighlyAvailable default injected by the Kubernetes API server [2], so this commit just fills in those defaults client-side to handle 4.8-admission-plugin vs. 4.7-Infra-CRD version skew. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1982868 [2]: https://github.com/openshift/api/blob/46e2fe0468512c88595dbc5997d890a97f2efb43/config/v1/types_infrastructure.go#L81-L100
wking
force-pushed
the
default-topology-for-rollbacks
branch
from
f0b0565
to
1e4cede
Compare
|
@wking: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/bugzilla refresh |
|
@wking: This pull request references Bugzilla bug 1982868, which is valid. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/valid-bug
|
The line I'm touching is from #833, so CC @cynepco3hahue, @mfojtik, and @sttts. |
|
Hrm, getting |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@wking IIUC the infrastructure object rollbacked to 4.7 before the Do you know if it is possible to recognize when the |
|
Obsoleted by #877. |
|
@wking: This pull request references Bugzilla bug 1982868. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Avoid blocking changes like:
when running against 4.7 versions of the Infrastructure CRD, which lack 4.8's topology properties. 4.8 and later CRDs will have the
HighlyAvailabledefault injected by the Kubernetes API server, so this commit just fills in those defaults client-side to handle 4.8-admission-plugin vs. 4.7-Infra-CRD version skew.