Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bug 1966477 audit.k8s.io/v1beta1 is deprecated #875

Closed
wants to merge 2 commits into from

Conversation

EmilyM1
Copy link

@EmilyM1 EmilyM1 commented Aug 2, 2021

What type of PR is this?

Bug fix on deprecated apiVersion

What this PR does / why we need it:

Pod logs are currently reporting the deprecated audit.k8s.io/v1beta1 is in use still. It is being triggered by a conditional.

Which issue(s) this PR fixes:

Bug 1966477

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2021
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 2, 2021
@openshift-ci-robot
Copy link

@EmilyM1: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmilyM1
To complete the pull request process, please assign mfojtik after the PR has been reviewed.
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from marun and mfojtik August 2, 2021 20:09
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Aug 2, 2021
@EmilyM1 EmilyM1 changed the title [WIP] Bug 1966477 [WIP] Bug 1966477 audit.k8s.io/v1beta1 is deprecated Aug 2, 2021
@EmilyM1
Copy link
Author

EmilyM1 commented Aug 4, 2021

/retest

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2021

@EmilyM1: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@EmilyM1: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2021

@EmilyM1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/images 58cbf2e link /test images
ci/prow/e2e-aws-fips 58cbf2e link /test e2e-aws-fips
ci/prow/verify-commits 58cbf2e link /test verify-commits
ci/prow/e2e-agnostic-cmd 58cbf2e link /test e2e-agnostic-cmd
ci/prow/e2e-gcp 58cbf2e link /test e2e-gcp
ci/prow/e2e-aws-serial 58cbf2e link /test e2e-aws-serial
ci/prow/k8s-e2e-gcp-serial 58cbf2e link /test k8s-e2e-gcp-serial
ci/prow/e2e-gcp-upgrade 58cbf2e link /test e2e-gcp-upgrade
ci/prow/k8s-e2e-conformance-aws 58cbf2e link /test k8s-e2e-conformance-aws
ci/prow/e2e-aws-csi 58cbf2e link /test e2e-aws-csi
ci/prow/k8s-e2e-gcp 58cbf2e link /test k8s-e2e-gcp
ci/prow/integration 58cbf2e link /test integration
ci/prow/verify 58cbf2e link /test verify
ci/prow/unit 58cbf2e link /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EmilyM1
Copy link
Author

EmilyM1 commented Aug 4, 2021

Closing this and fixing downstream to avoid issues when change gets rebased in from upstream in future.

@EmilyM1 EmilyM1 closed this Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants