[release-4.8] Bug 1995714: UPSTREAM: <carry>: admission/managementcpusoverride: cover the roll-back case #895

openshift-cherrypick-robot · 2021-08-19T16:33:47Z

This is an automated cherry-pick of #877

/assign cynepco3hahue

…ack case During the upgrade and roll-back flow 4.7->4.8->4.7, the topology related fields under the infrastructure can be empty because the old API does not support them. The code will equal the empty infrastructure section with the current one. When the status has some other non-empty field, and topology fields are empty, we assume that the cluster currently passes via roll-back and not via the clean install. Signed-off-by: Artyom Lukianov <alukiano@redhat.com>

openshift-ci-robot · 2021-08-19T16:33:54Z

@openshift-cherrypick-robot: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

843682b|UPSTREAM: : admission/managementcpusoverride: cover the roll-back case: does not specify an upstream backport in the commit message

openshift-ci · 2021-08-19T16:33:58Z

@openshift-cherrypick-robot: Bugzilla bug 1982868 has been cloned as Bugzilla bug 1995714. Retitling PR to link against new bug.
/retitle [release-4.8] Bug 1995714: UPSTREAM: : admission/managementcpusoverride: cover the roll-back case

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-19T16:34:04Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1995714, which is invalid:

expected dependent Bugzilla bug 1982868 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cynepco3hahue · 2021-08-22T15:55:21Z

/retest

cynepco3hahue · 2021-08-23T09:03:42Z

/retest

cynepco3hahue · 2021-08-23T12:33:03Z

/retest

cynepco3hahue · 2021-08-23T14:42:15Z

/retest

cynepco3hahue · 2021-08-23T14:42:26Z

/bugzilla refresh

openshift-ci · 2021-08-23T14:44:32Z

@cynepco3hahue: This pull request references Bugzilla bug 1995714, which is invalid:

expected dependent Bugzilla bug 1982868 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sttts · 2021-08-25T07:50:58Z

/retest
/approve
/lgtm

openshift-ci · 2021-08-25T07:53:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-08-25T14:54:32Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-25T15:18:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-25T19:08:30Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-25T20:46:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-25T23:09:31Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-26T01:00:37Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-08-26T01:00:41Z

@openshift-bot: This pull request references Bugzilla bug 1995714, which is invalid:

expected dependent Bugzilla bug 1982868 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-07T01:00:43Z

@openshift-bot: This pull request references Bugzilla bug 1995714, which is invalid:

expected dependent Bugzilla bug 1982868 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-08T01:01:18Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-08T01:01:21Z

@openshift-bot: This pull request references Bugzilla bug 1995714, which is invalid:

expected dependent Bugzilla bug 1982868 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 1982868 to target a release in 4.9.0, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-09T01:00:24Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-09T01:00:31Z

@openshift-bot: This pull request references Bugzilla bug 1995714, which is invalid:

expected dependent Bugzilla bug 1982868 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
expected dependent Bugzilla bug 1982868 to target a release in 4.9.0, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-10T01:01:10Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-10T01:01:14Z

@openshift-bot: This pull request references Bugzilla bug 1995714, which is invalid:

expected dependent Bugzilla bug 1982868 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-11T01:01:11Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-11T01:01:14Z

@openshift-bot: This pull request references Bugzilla bug 1995714, which is invalid:

expected dependent Bugzilla bug 1982868 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-12T01:00:54Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-12T01:00:58Z

@openshift-bot: This pull request references Bugzilla bug 1995714, which is invalid:

expected dependent Bugzilla bug 1982868 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-13T01:00:54Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-13T01:00:57Z

@openshift-bot: This pull request references Bugzilla bug 1995714, which is invalid:

expected dependent Bugzilla bug 1982868 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-09-14T01:00:34Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-09-14T01:00:39Z

@openshift-bot: This pull request references Bugzilla bug 1995714, which is invalid:

expected dependent Bugzilla bug 1982868 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cynepco3hahue · 2021-09-14T10:40:07Z

/bugzilla refresh

openshift-ci · 2021-09-14T10:40:15Z

@cynepco3hahue: This pull request references Bugzilla bug 1995714, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.z) matches configured target release for branch (4.8.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1982868 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1982868 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hardys · 2021-09-17T09:32:29Z

[patch-manager] Approving for cherry-pick with a score of 0.70

openshift-bot · 2021-09-17T12:38:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-17T15:38:27Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-17T16:04:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-17T18:27:26Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-17T22:19:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-09-18T00:44:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-09-18T02:35:01Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/kubernetes#895

Bugzilla bug 1995714 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot assigned cynepco3hahue Aug 19, 2021

openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 19, 2021

openshift-cherrypick-robot mentioned this pull request Aug 19, 2021

Bug 1982868: UPSTREAM: <carry>: admission/managementcpusoverride: cover the roll-back case #877

Merged

openshift-ci bot changed the title ~~[release-4.8] Bug 1982868: UPSTREAM: <carry>: admission/managementcpusoverride: cover the roll-back case~~ [release-4.8] Bug 1995714: UPSTREAM: <carry>: admission/managementcpusoverride: cover the roll-back case Aug 19, 2021

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 19, 2021

openshift-ci bot requested review from mfojtik and soltysh August 19, 2021 16:34

openshift-ci bot assigned sttts Aug 25, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 14, 2021

soltysh removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Sep 15, 2021

hardys added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 17, 2021

openshift-merge-robot merged commit a620f50 into openshift:release-4.8 Sep 18, 2021

[release-4.8] Bug 1995714: UPSTREAM: <carry>: admission/managementcpusoverride: cover the roll-back case #895

[release-4.8] Bug 1995714: UPSTREAM: <carry>: admission/managementcpusoverride: cover the roll-back case #895

Conversation

openshift-cherrypick-robot commented Aug 19, 2021

openshift-ci-robot commented Aug 19, 2021

openshift-ci bot commented Aug 19, 2021

openshift-ci bot commented Aug 19, 2021

cynepco3hahue commented Aug 22, 2021

cynepco3hahue commented Aug 23, 2021

cynepco3hahue commented Aug 23, 2021

cynepco3hahue commented Aug 23, 2021

cynepco3hahue commented Aug 23, 2021

openshift-ci bot commented Aug 23, 2021

sttts commented Aug 25, 2021

openshift-ci bot commented Aug 25, 2021

openshift-bot commented Aug 25, 2021

openshift-bot commented Aug 25, 2021

openshift-bot commented Aug 25, 2021

openshift-bot commented Aug 25, 2021

openshift-bot commented Aug 25, 2021

openshift-bot commented Aug 26, 2021

openshift-ci bot commented Aug 26, 2021

openshift-ci bot commented Sep 7, 2021

openshift-bot commented Sep 8, 2021

openshift-ci bot commented Sep 8, 2021

openshift-bot commented Sep 9, 2021

openshift-ci bot commented Sep 9, 2021

openshift-bot commented Sep 10, 2021

openshift-ci bot commented Sep 10, 2021

openshift-bot commented Sep 11, 2021

openshift-ci bot commented Sep 11, 2021

openshift-bot commented Sep 12, 2021

openshift-ci bot commented Sep 12, 2021

openshift-bot commented Sep 13, 2021

openshift-ci bot commented Sep 13, 2021

openshift-bot commented Sep 14, 2021

openshift-ci bot commented Sep 14, 2021

cynepco3hahue commented Sep 14, 2021

openshift-ci bot commented Sep 14, 2021

hardys commented Sep 17, 2021

openshift-bot commented Sep 17, 2021

openshift-bot commented Sep 17, 2021

openshift-bot commented Sep 17, 2021

openshift-bot commented Sep 17, 2021

openshift-bot commented Sep 17, 2021

openshift-bot commented Sep 18, 2021

openshift-ci bot commented Sep 18, 2021