Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1993753: UPSTREAM: 104348: Pass additional flags to subpath mount to avoid fla… #941

Merged

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Sep 9, 2021

/cc @openshift/storage

@openshift-ci
Copy link

openshift-ci bot commented Sep 9, 2021

@dobsonj: An error was encountered searching for bug 1993753 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. code 102: You are not authorized to access bug #1993753. Most likely the bug has been restricted for internal development processes and we cannot grant access. If you are a Red Hat customer with an active subscription, please visit the Red Hat Customer Portal for assistance with your issue If you are a Fedora Project user and require assistance, please consider using one of the mailing lists we host for the Fedora Project.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1993753: UPSTREAM: 104348: Pass additional flags to subpath mount to avoid fla…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Sep 9, 2021
@openshift-ci-robot
Copy link

@dobsonj: the contents of this pull request could be automatically validated.

The following commits are valid:

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Sep 9, 2021
@dobsonj
Copy link
Member Author

dobsonj commented Sep 9, 2021

/retest
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2021
@dobsonj
Copy link
Member Author

dobsonj commented Sep 10, 2021

/retest

1 similar comment
@dobsonj
Copy link
Member Author

dobsonj commented Sep 10, 2021

/retest

@jsafrane
Copy link

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2021
@jsafrane
Copy link

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2021
@mfojtik
Copy link
Member

mfojtik commented Sep 15, 2021

/approve

@mfojtik
Copy link
Member

mfojtik commented Sep 15, 2021

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2021

@mfojtik: An error was encountered searching for bug 1993753 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. code 102: You are not authorized to access bug #1993753. Most likely the bug has been restricted for internal development processes and we cannot grant access. If you are a Red Hat customer with an active subscription, please visit the Red Hat Customer Portal for assistance with your issue If you are a Fedora Project user and require assistance, please consider using one of the mailing lists we host for the Fedora Project.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@duanwei33
Copy link

/bugzilla cc-qa

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 16, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2021

@duanwei33: This pull request references Bugzilla bug 1993753, which is invalid:

  • expected Bugzilla bug 1993753 to depend on a bug targeting a release in 4.8.0, 4.8.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 16, 2021
@duanwei33
Copy link

duanwei33 commented Sep 16, 2021

I'm following JIRA issue DPTP-660 to do the pre-merge verification. Used the cluster-bot launching an env with the still open but Dev-approved PR(s).
The bug is pre-merge verified. So per JIRA issue DPTP-660's Description process, adding QE lgtm:
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, duanwei33, jsafrane, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link

openshift-ci bot commented Sep 17, 2021

@openshift-bot: This pull request references Bugzilla bug 1993753, which is invalid:

  • expected Bugzilla bug 1993753 to depend on a bug targeting a release in 4.8.0, 4.8.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hardys
Copy link

hardys commented Sep 17, 2021

I'm following JIRA issue DPTP-660 to do the pre-merge verification. Used the cluster-bot launching an env with the still open but Dev-approved PR(s).
The bug is pre-merge verified. So per JIRA issue DPTP-660's Description process, adding QE lgtm:
/lgtm

[patch-manager] I believe we also require the qe-approved label, but I'm taking this comment as approval and will apply the label myself :)

@hardys hardys added the qe-approved Signifies that QE has signed off on this PR label Sep 17, 2021
@hardys
Copy link

hardys commented Sep 17, 2021

[patch-manager] #940 landed and was verified, this PR has qe-approved from pre-merge testing, adding bugzilla/valid-bug and cherry-pick-approved labels

@hardys hardys added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 17, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Sep 17, 2021

@dobsonj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp fb92e81 link /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bbbc079 into openshift:release-4.7 Sep 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 17, 2021

@dobsonj: All pull requests linked via external trackers have merged:

Bugzilla bug 1993753 has been moved to the MODIFIED state.

In response to this:

Bug 1993753: UPSTREAM: 104348: Pass additional flags to subpath mount to avoid fla…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants