Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.9] Bug 2003306: UPSTREAM: 104817: kubelet: Rejected pods should be filtered from admission #949

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #948

/assign rphillips

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: the contents of this pull request could be automatically validated.

The following commits are valid:

@openshift-ci
Copy link

openshift-ci bot commented Sep 11, 2021

@openshift-cherrypick-robot: Bugzilla bug 2003269 has been cloned as Bugzilla bug 2003306. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2003306: UPSTREAM: 104817: kubelet: Rejected pods should be filtered from admission

In response to this:

[release-4.9] Bug 2003269: UPSTREAM: 104817: kubelet: Rejected pods should be filtered from admission

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2003269: UPSTREAM: 104817: kubelet: Rejected pods should be filtered from admission [release-4.9] Bug 2003306: UPSTREAM: 104817: kubelet: Rejected pods should be filtered from admission Sep 11, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Sep 11, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 11, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2003306, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2003269 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2003269 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to this:

[release-4.9] Bug 2003306: UPSTREAM: 104817: kubelet: Rejected pods should be filtered from admission

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 11, 2021
@nee1esh
Copy link

nee1esh commented Sep 13, 2021

/retest-required

3 similar comments
@nee1esh
Copy link

nee1esh commented Sep 13, 2021

/retest-required

@nee1esh
Copy link

nee1esh commented Sep 13, 2021

/retest-required

@nee1esh
Copy link

nee1esh commented Sep 14, 2021

/retest-required

@nee1esh
Copy link

nee1esh commented Sep 14, 2021

/retest

1 similar comment
@tsmetana
Copy link
Member

/retest

@jsafrane
Copy link

I am fixing cinder and manila jobs to be optional in openshift/release#21898. Feel free to override the tests, they're known to be faulty and we have BZs to fix them.

@mrunalp mrunalp added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Sep 15, 2021
@mrunalp
Copy link
Member

mrunalp commented Sep 15, 2021

/override e2e-openstack-csi-manila

@mrunalp
Copy link
Member

mrunalp commented Sep 15, 2021

/override e2e-openstack-csi-cinder

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2021

@mrunalp: mrunalp unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override e2e-openstack-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2021

@mrunalp: mrunalp unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override e2e-openstack-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link

deads2k commented Sep 15, 2021

I am fixing cinder and manila jobs to be optional in openshift/release#21898. Feel free to override the tests, they're known to be faulty and we have BZs to fix them.

Can we get links?

/hold
/override ci/prow/e2e-openstack-csi-manila
/override ci/prow/e2e-openstack-csi-cinder

held pending bugzilla links that demonstrate we are not regressing customers on code that now fails tests.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2021
@deads2k
Copy link

deads2k commented Sep 15, 2021

this is kubernetes#104918

@deads2k deads2k closed this Sep 15, 2021
@deads2k deads2k reopened this Sep 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2021

@openshift-cherrypick-robot: An error was encountered adding this pull request to the external tracker bugs for bug 2003306 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. JSONRPC error 32000: Red Hat Bugzilla's database reported a query serialization error. Most likely this occurred because another user or process attempted to change the same data that you were attempting to change. Please press Back and retry the transaction.
 UPDATE bugs SET delta_ts = ? WHERE bug_id = ? at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1517. 

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Bug 2003306: UPSTREAM: 104817: kubelet: Rejected pods should be filtered from admission

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2003306. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

[release-4.9] Bug 2003306: UPSTREAM: 104817: kubelet: Rejected pods should be filtered from admission

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2021

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-openstack-csi-cinder, ci/prow/e2e-openstack-csi-manila

In response to this:

I am fixing cinder and manila jobs to be optional in openshift/release#21898. Feel free to override the tests, they're known to be faulty and we have BZs to fix them.

Can we get links?

/hold
/override ci/prow/e2e-openstack-csi-manila
/override ci/prow/e2e-openstack-csi-cinder

held pending bugzilla links that demonstrate we are not regressing customers on code that now fails tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nee1esh
Copy link

nee1esh commented Sep 15, 2021

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2021

@nee1esh: This pull request references Bugzilla bug 2003306, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2003269 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2003269 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nee1esh
Copy link

nee1esh commented Sep 15, 2021

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2021

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-csi 063f4ad link /test e2e-aws-csi
ci/prow/e2e-openstack-csi-manila 063f4ad link /test e2e-openstack-csi-manila
ci/prow/e2e-openstack-csi-cinder 063f4ad link /test e2e-openstack-csi-cinder

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rphillips
Copy link

/hold cancel

This PR is 1 of 2 PRs needed to unblock the 4.9 release.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2021
@mrunalp mrunalp added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 16, 2021
@openshift-merge-robot openshift-merge-robot merged commit f1fbf81 into openshift:release-4.9 Sep 16, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2003306 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2003306: UPSTREAM: 104817: kubelet: Rejected pods should be filtered from admission

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants