"[CNV-36073](https://issues.redhat.com//browse/CNV-36073): Sync upstream kubevirt-csi 2024-04-08" #38
Conversation
Instead of using the PV to get the storage class use the PVC storage class instead. If it is nil then k8s version is < 1.28 and we return an error indicating we cannot determine the storage class name. Signed-off-by: Alexander Wels <awels@redhat.com>
Read the mapping from the driver-config ConfigMap. Use this mapping to determine if a snapshot can be created with the storage/volume snapshot class combination. If not possible return an error with a list of the possible snapshot classes. Signed-off-by: Alexander Wels <awels@redhat.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
…ner (kubevirt#104) Signed-off-by: David Vossel <davidvossel@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels, davidvossel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-kubevirt-aws-csi |
|
@awels: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retitle "NO-JIRA - Sync upstream kubevirt-csi 2024-04-08" |
openshift-ci
bot
changed the title
|
/jira refresh |
|
@davidvossel: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
awels
changed the title
|
/retitle "NO-JIRA: Sync upstream kubevirt-csi 2024-04-08" |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@awels: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle "CNV-36073 - Sync upstream kubevirt-csi 2024-04-08" |
openshift-ci
bot
changed the title
|
/retitle "CNV-36073: Sync upstream kubevirt-csi 2024-04-08" |
openshift-ci
bot
changed the title
|
@awels: This pull request references CNV-36073 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@davidvossel: This pull request references CNV-36073 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle "NO-JIRA: Sync upstream kubevirt-csi 2024-04-08" |
openshift-ci
bot
changed the title
|
@awels: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle "CNV-36073: Sync upstream kubevirt-csi 2024-04-08" |
openshift-ci
bot
changed the title
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-kubevirt-csi-driver-container-v4.16.0-202404152212.p0.gc43f182.assembly.stream.el9 for distgit ose-kubevirt-csi-driver-rhel8. |
What this PR does / why we need it:
Complete support for snapshots, minus enabling e2e tests
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: