New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1754046: Ensure kuryr webhook is running before other operators' pods #108
Bug 1754046: Ensure kuryr webhook is running before other operators' pods #108
Conversation
0edcc35
to
1765c49
Compare
@luis5tb: This pull request references Bugzilla bug 1779654, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@luis5tb: This pull request references Bugzilla bug 1754046, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Luis. Just a few suggestions:
k8s = k8s_client.K8sClient(api_root) | ||
# list of namespaces with operators to delete | ||
for ns in app.config['ns_to_clear']: | ||
pods = k8s.get('{}/namespaces/{}/pods'.format( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be safer to handle any Kubernetes exception that might be raised.
for pod in pods.get('items'): | ||
options = pod['spec'].get('dnsConfig', {}).get('options', []) | ||
if not [o for o in options if o['name'] == 'use-vc']: | ||
k8s.delete('{}/namespaces/{}/pods/{}'.format( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Change-Id: Id74eb4d8a7b1ea7ec97085de85f29244bbda25ea
1765c49
to
d8532bb
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, luis5tb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.3 |
@luis5tb: new pull request created: #110 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-sdn: more service-catalog netnamespace fixes
This PR ensure that Kuryr-admission-controller is up and ready (including its associated service) before other operators so that the proper dns configuration is enforced