Bug 1792239: Avoid KeyError when deleting NPs #141
Conversation
It seems that when an namespace deletion fails for some reason and it is retried, if there are other NPs created, some of the unused ports can be reused and moved from one sg_key to another, therefore raising the KeyError on the retry. This patch ensure that if the sg_key was already deleted, the retry skips it instead of failing Change-Id: Ifcebf7660861738128606342dc6dab00186878b5 Closes-Bug: 1860106
Change-Id: I16f782ea0c4d454428816d6903f25421615ada23
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@luis5tb: This pull request references Bugzilla bug 1792239, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
size/XS
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, luis5tb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@luis5tb: All pull requests linked via external trackers have merged. Bugzilla bug 1792239 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.3 |
|
@luis5tb: new pull request created: #142 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…_and_stderr_to_dev_null Pipe socat stdout and stderr to dev null
It seems that when an namespace deletion fails for some reason and
it is retried, if there are other NPs created, some of the unused
ports can be reused and moved from one sg_key to another, therefore
raising the KeyError on the retry.
This patch ensure that if the sg_key was already deleted, the retry
skips it instead of failing
Change-Id: Ifcebf7660861738128606342dc6dab00186878b5