Rebase openshift/kuryr-kubernetes from https://opendev.org/openstack/kuryr-kubernetes #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like AddHandler and DelHandler are not used by kuryr-daemon or CNI code anymore and this commit gets rid of them. Change-Id: I28f4a1b7d6b683d81970bf6a4cfb3fe6d95dfb90
There's no point to keep non-voting jobs on the gate pipeline and this commit makes sure that OVN job there is voting. Change-Id: I1fddc58d30e8d38f7922fe48f8e57453f82d72ef
The USE_SYSTEMD variable is to be dropped from devstack[0], as running with systemd is the only option now. Drop it's usage in our plugin. [0] https://review.opendev.org/703734 Change-Id: I79085c247f64cf52ad7d4ee66a775607491faa2f
OpenStackSDK is raising a SDKException when a subnet does not exist, causing the controller to continuosly restart. This commit protects from such scenario by ignoring when such exception happens with certain message. Closes-bug: 1861314 Change-Id: I82238280a2924f1979c5b0b99399c4570093b360
Implements: blueprint switch-to-openstacksdk Change-Id: I5db29bcd65e5f97e1c94ee2d863e81cd63bf8d4a
Drivers nested_macvlan_vif and sriov have _get_port_request helper method for generating payload used for port creation. There was inconsistency in it's usage. In this patch we stright this up. Implements: blueprint switch-to-openstacksdk Change-Id: Iab77c0ba67d836c49f91aa9d896d47448e734e79
Route pods from openshift can be used instead and the code is not being used/maintained. Change-Id: I76448752ba07f4b30dbfa783c2ae99d46e730eaf
Support for OpenShift Routes (Ingress) is not maintained by anyone, not really tested and there are better ways to do it, so let's remove that code from Kuryr. Support for namespace isolation was done to mimic one of the modes of openshift-sdn. It doesn't seem to make any sense to keep supporting it if Network Policy support can provide the same isolation. Change-Id: I8cfb3c50f491a5dbbfe6fa20b81ee1d0f8c6b4a7
When a network policy is updated we compare all the existing sg rules with the current sg rules in order to add/remove rules. When there are existing rules repeated only the first occurence of the rule is identified as to be kept, and the second one is not, causing the rule on the current sg rules to not be created, as it matches an existent sg rule that was not meant to be kept, causing a breakage on the update NP CRD which does not allow sg rules with no ID. This commit fixes the issue by ensuring that no sg rule is repeated on the NP CRD. Closes-bug: 1861624 Change-Id: I5170e0177a87c2dde77f19f6a7ae09ca2a06c65e
NetworkPolicy can replicate what namespace isolation does (and much more), so we are removing the code that is not needed Change-Id: Ib79c21cb92c522744658a204001383b6c0e98846
Add DPDK support for nested K8s pods. Patch includes a new VIF driver on the controller and a new CNI binding driver. This patch introduces dependency from os-vif v.1.12.0, since there a new vif type. Change-Id: I6be9110192f524325e24fb97d905faff86d0cfef Implements: blueprint nested-dpdk-support Co-Authored-By: Kural Ramakrishnan <kuralamudhan.ramakrishnan@intel.com> Co-Authored-By: Marco Chiappero <marco.chiappero@intel.com> Signed-off-by: Alexey Perevalov <a.perevalov@samsung.com> Signed-off-by: Danil Golov <d.golov@samsung.com>
… not found" This reverts commit 7691e94. The 0.41.0 version of openstacksdk is free of this issue. Also we still need to keep the handle_neutron_errors for support of older openstacksdks. Change-Id: I5bffda72cc8f1e348581ef38cb68cb8336e2af59
Recently, we switched almost all drivers and handlers within kuryr-kubernetes to use OpenStackSDK client instead of neutron client. In this change we propose to deprecate further usage of neutron client in favor od openstacksdk-client. Change-Id: Iea6c4c8a9181f3e2987fc28718c52fe1b230b931
With the removal of OpenShift Routes support we don't need permissions to access it anymore. Same happens with Ingress resources. Change-Id: I9ba464c9c485e4f186dd02763a6ef4c270df9e77
This commit adds information about required Kuryr Kubernetes user permissions when RBAC is enabled to manual installation guide. Change-Id: I6175350eff4a8f05b7fa9ba020ad129a455feacd
This commit enables basic support for IPv6 pod and service subnet. Also two gates are added - an OVS and OVN one, both as non-voting at the moment. The DevStack changes are mostly about putting correct --ethertype on SGs, using ip6tables and IPv6 subnetpool. The Kuryr change required putting IPv6 address of K8s API in brackets. Please note that this unblocks just the most basic use case, network policy support will still not work with IPv6. Depends-On: https://review.opendev.org/#/c/707103/ Implements: blueprint kuryr-ipv6-support Change-Id: Id56b622a5038d8e5c072aa00a9f38a2418e6268f
… subnet not found""
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @kuryr-bot. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/XXL
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
|
/retest Everything seems unrelated here. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, kuryr-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
MaysaMacedo
pushed a commit
to MaysaMacedo/kuryr-kubernetes-1
that referenced
this pull request
Jul 1, 2021
OVN Kubernetes fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.