Rebase from openstack/kuryr-kubernetes #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several issues with the OpenShift job. First of all it's running OpenShift 3.11, based on Kubernetes 1.11 which was released almost 2 years ago. According to K8s deprecation policy [1] the minimum support period for an API is just one year, so we might now start to see some mismatches between supported features (as e.g. with CRDs beta version, which just got deprecated, but stable version is not supported by API 1.11). Second of all - it's now constantly failing on every patch for an unknown reason. It's worth noting that upgrading the CI to use OpenShift 4.x is extremely troublesome, as now OpenShift expects the installation to be run with the full installer, which only supports nested deployments. And nested deployments are really hard to do in the gate as we don't have any guarantee of nested virtualization here. This commit moves the OpenShift job to experimental queue. [1] https://kubernetes.io/docs/reference/using-api/deprecation-policy/ Change-Id: Ibe683d008f26debd45bc0a0713d8141653860455
Change-Id: I4ac14c31c55bb4d1d77c822af10349df51ca70c5
openshift-ci-robot
added
size/XS
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, gryf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MaysaMacedo
pushed a commit
to MaysaMacedo/kuryr-kubernetes-1
that referenced
this pull request
Jul 1, 2021
Don't set a network status at all if we're not managing networking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.