Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase openshift/kuryr-kubernetes from https://opendev.org/openstack/kuryr-kubernetes #177

Merged
merged 9 commits into from Mar 5, 2020

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Mar 5, 2020

No description provided.

dulek and others added 9 commits February 26, 2020 12:00
In Kubernetes 1.16 CRDs got out of beta and added to regular
apiextensions.k8s.io/v1. This was accompanied with some format changes.
This patch updates our CRD definitions to new version.

Change-Id: Ib5e64fe72581ef601e5df2e317900566cd476470
In lower-constraints we now have openstacksdk 0.36.0 meaning that tags
for Octavia resources are normally supported. This commit removes the
hack that was making POST requests on LB resources manually to
workaround the fact that older versions of the lib were not supporting
tags.

Change-Id: I22f403407b4d83af3cf7093a15318e40b0186386
Change-Id: Ie35318df8ad7834f98060f0dc742a2cfd5949089
Since we already migrated fully to Python3, it's time to also remove
bits needed for Python2. One of those libs is six.

Change-Id: Ib984d7b4b3c1048ed091c78986c634689a8ace8c
Per request from infra cloud providers we need to disable world-facing
DNS that is the coredns and find a way to run it privately on the gate
VMs. Which won't be that easy, as there's unbind bound to 127.0.0.1:53,
but let's see if we'll be able to come up with something.

Meanwhile this change shouldn't hurt too much as we were yet to utilize
the coredns deployment and I think it wasn't even working on the gate.

Change-Id: I0c671b533f2babef172b46c36f62fba929d724c5
…t-master

Change-Id: I0b320bfc19390ba18b5ab418dd3c2bf78952ffb3
@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 5, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2020
@MaysaMacedo
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 058ec18 into openshift:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants