Bug 1810571: Raise K8sResourceNotFound for all client methods #178
Conversation
Seems like K8sClient wasn't raising K8sResourceNotFound exception on 404 from all the methods, e.g. patch. This commit makes sure that is no longer the case and any 404 results in K8sResourceNotFound exception. Change-Id: I23b947ef5f8c56429b5c69b73489fec19c44bd7e Closes-Bug: 1865893
…t-master Change-Id: Ib4ecfe23b83338d486a6194f2797cb5ab504d6cf
|
@dulek: This pull request references Bugzilla bug 1810571, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, gryf, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dulek: All pull requests linked via external trackers have merged. Bugzilla bug 1810571 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@dulek: new pull request created: #181 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Seems like K8sClient wasn't raising K8sResourceNotFound exception on 404
from all the methods, e.g. patch. This commit makes sure that is no
longer the case and any 404 results in K8sResourceNotFound exception.