Rebase openshift/kuryr-kubernetes from https://opendev.org/openstack/kuryr-kubernetes #186
Conversation
This commit converts nested_dpdk_vif and nested_macvlan_vif drivers to use openstacksdk. The latter required a bit of a hack visible in the clients.py - the openstacksdk's Port resource is injected with additional header parameter to be able to use If-Match header when updating allowed_address_pairs on the parent VIFs. What's missing here is removal of some hacks still present in os_vif_util.py. Change-Id: I90b0ae7650aa36fb321d66b9d95fc8fd36249896
Inherit sriov driver from the BaseBindingDriver. SRIOV driver already implements the needed methods and should align with driver class hierarchy. Change-Id: I60d487552b15b09776b83796c2eb52cbbce44eb3
Seems like we don't need sgId on KuryrNet CRD, it's not written anywhere and only read in one place. This patch removes it. Change-Id: Ia5a0f0dd89d72b16189cb33e97720bc6171239ac
|
Hi @kuryr-bot. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
needs-ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, kuryr-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
run-locally.sh: add from-scratch cluster up capability
No description provided.