Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase openshift/kuryr-kubernetes from https://opendev.org/openstack/kuryr-kubernetes #190

Merged
merged 3 commits into from Mar 16, 2020
Merged

Rebase openshift/kuryr-kubernetes from https://opendev.org/openstack/kuryr-kubernetes #190

merged 3 commits into from Mar 16, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 16, 2020

No description provided.

Danil Golov and others added 3 commits March 13, 2020 13:33
Make node annotations with pci addresses optional
cacd080 
This patch adds new option to CM that enables annotations
to nodes. Node annotations are useless before
sriov-nic-agent is installed on nodes. By default this
option is set to False, so annotations will not be set and
direct ports will not be active in neutron.

Change-Id: Ie6f141df59c601b74fb949a86e92d68115ffa5fb
Signed-off-by: Danil Golov <d.golov@samsung.com>
@openstack-gerrit
Merge "Make node annotations with pci addresses optional"
6db604d
Merge https://opendev.org/openstack/kuryr-kubernetes:master into master
f8dd125
@openshift-ci-robot
Copy link

Hi @kuryr-bot. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 16, 2020
@dulek
Copy link
Contributor

dulek commented Mar 16, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, kuryr-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit d696c9e into openshift:master Mar 16, 2020
MaysaMacedo pushed a commit to MaysaMacedo/kuryr-kubernetes-1 that referenced this pull request Jul 1, 2021
@openshift-merge-robot
Merge pull request openshift#190 from pecameron/sdn447
06d829c 
Add readinessProbe to ovn-kubernetes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celebdor celebdor Awaiting requested review from celebdor

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

Assignees

@dulek dulek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@openshift-ci-robot @dulek @openshift-merge-robot