Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1818061: Ensure no attempt to deleted sg rules owned by Octavia happens #200

Merged
merged 3 commits into from Apr 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 1, 2020

No description provided.

MaysaMacedo and others added 3 commits March 26, 2020 09:05
When updating the LB security group with only the rules applied
on a Network Policy we are also considering the sg rules owned by
octavia, this result on failure when trying to delete the rules
as this operation is not allowed.

This commit ensures only the rules owned by the correct tenant
are deleted.

Change-Id: I06ece3fd93d1408f6023d3daf0ba152fe7dfe4e4
Closes-bug: 1869063
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 1, 2020
@openshift-ci-robot
Copy link

Hi @kuryr-bot. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb luis5tb changed the title Rebase openshift/kuryr-kubernetes from https://opendev.org/openstack/kuryr-kubernetes Bug 1818061: Ensure no attempt to deleted sg rules owned by Octavia happens Apr 1, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 1, 2020
@openshift-ci-robot
Copy link

@kuryr-bot: This pull request references Bugzilla bug 1818061, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1818061: Ensure no attempt to deleted sg rules owned by Octavia happens

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb
Copy link
Contributor

luis5tb commented Apr 1, 2020

/ok-to-test

@luis5tb
Copy link
Contributor

luis5tb commented Apr 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2020
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 1, 2020
@luis5tb
Copy link
Contributor

luis5tb commented Apr 1, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kuryr-bot, luis5tb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3fcf396 into openshift:master Apr 1, 2020
@openshift-ci-robot
Copy link

@kuryr-bot: All pull requests linked via external trackers have merged: openshift/kuryr-kubernetes#200. Bugzilla bug 1818061 has been moved to the MODIFIED state.

In response to this:

Bug 1818061: Ensure no attempt to deleted sg rules owned by Octavia happens

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb
Copy link
Contributor

luis5tb commented Apr 1, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot

@luis5tb: new pull request created: #201

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb
Copy link
Contributor

luis5tb commented Apr 1, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@luis5tb: All pull requests linked via external trackers have merged: openshift/kuryr-kubernetes#200. Bugzilla bug 1818061 has been moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants