Bug 1824258: Ensure LB state annotation sg matches the SG on the LB #215
Conversation
As soon as the service is created it's possible that the backend pods are not yet created resulting in an lbaas_spec annotation with no security groups defined, and so security group rules can turn out to be removed from the load balancer sg. This commit ensures the lbaas_state annotation contains the updated sgs. Closes-bug: 1872962 Change-Id: I296d16a627e39e6534ad9c1dff18b4564624d35d
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MaysaMacedo
changed the title
|
@MaysaMacedo: This pull request references Bugzilla bug 1824258, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/medium
bugzilla/valid-bug
|
/cherry-pick release-4.4 |
|
@MaysaMacedo: new pull request created: #216 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@luis5tb: All pull requests linked via external trackers have merged: openshift/kuryr-kubernetes#215. Bugzilla bug 1824258 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
adding additional sdn alerts to prometheus
As soon as the service is created it's possible that the backend pods
are not yet created resulting in an lbaas_spec annotation with no
security groups defined, and so security group rules can turn out
to be removed from the load balancer sg. This commit ensures the
lbaas_state annotation contains the updated sgs.