Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1828699: Ensure NP are enforced on SVC with different port and target port #227

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #223

/assign luis5tb

This patch ensure the proper listener id is found and its associated
security groups are updated.

Change-Id: I72120c33debddfe6ba29c8c0152a0cef4e96a6eb
Closes-Bug: 1875428
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Not creating new clone for Bugzilla bug 1828388 as Bugzilla bug 1828699 has been detected as a clone for the correct target release of this cherrypick. Running refresh:
/bugzilla refresh

In response to this:

[release-4.3] [release-4.4] Bug 1828388: Ensure NP are enforced on SVC with different port and target port

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 7, 2020
@openshift-ci-robot
Copy link

@openshift-ci-robot: This pull request references Bugzilla bug 1828388, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected dependent Bugzilla bug 1828387 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

@openshift-cherrypick-robot: Not creating new clone for Bugzilla bug 1828388 as Bugzilla bug 1828699 has been detected as a clone for the correct target release of this cherrypick. Running refresh:
/bugzilla refresh

In response to this:

[release-4.3] [release-4.4] Bug 1828388: Ensure NP are enforced on SVC with different port and target port

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb luis5tb changed the title [release-4.3] [release-4.4] Bug 1828388: Ensure NP are enforced on SVC with different port and target port [release-4.3] Bug 1828699: Ensure NP are enforced on SVC with different port and target port May 7, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1828699, which is invalid:

  • expected dependent Bugzilla bug 1828388 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
  • expected dependent Bugzilla bug 1828387 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.3] Bug 1828699: Ensure NP are enforced on SVC with different port and target port

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb
Copy link
Contributor

luis5tb commented May 8, 2020

/lgtm

@luis5tb
Copy link
Contributor

luis5tb commented May 8, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luis5tb, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2020
@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link

@openshift-bot: This pull request references Bugzilla bug 1828699, which is invalid:

  • expected dependent Bugzilla bug 1828388 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1828387 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link

@openshift-bot: This pull request references Bugzilla bug 1828699, which is invalid:

  • expected dependent Bugzilla bug 1828388 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1828387 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link

@openshift-bot: This pull request references Bugzilla bug 1828699, which is invalid:

  • expected dependent Bugzilla bug 1828388 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1828387 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb
Copy link
Contributor

luis5tb commented May 11, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@luis5tb: This pull request references Bugzilla bug 1828699, which is invalid:

  • expected dependent Bugzilla bug 1828387 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb
Copy link
Contributor

luis5tb commented May 11, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 11, 2020
@openshift-ci-robot
Copy link

@luis5tb: This pull request references Bugzilla bug 1828699, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1828388 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1828388 targets the "4.4.z" release, which is one of the valid target releases: 4.4.0, 4.4.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 11, 2020
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 13, 2020
@sdodson
Copy link
Member

sdodson commented May 13, 2020

/retitle Bug 1828699: Ensure NP are enforced on SVC with different port and target port

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1828699: Ensure NP are enforced on SVC with different port and target port Bug 1828699: Ensure NP are enforced on SVC with different port and target port May 13, 2020
@openshift-merge-robot openshift-merge-robot merged commit e2b2c98 into openshift:release-4.3 May 13, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/kuryr-kubernetes#227. Bugzilla bug 1828699 has been moved to the MODIFIED state.

In response to this:

Bug 1828699: Ensure NP are enforced on SVC with different port and target port

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MaysaMacedo pushed a commit to MaysaMacedo/kuryr-kubernetes-1 that referenced this pull request Jul 1, 2021
Improve OpenStack resource naming and tagging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants