Bug 1838985: Skip LB sg update when no endpoint is found #240
Conversation
When a pod event is handled it's possible that a Network Policy and Service are affected by that pod and the LB sg of selected services needs to be updated. However, the endpoints for the matched service may not be yet present or were deleted, resulting in a NotFound exception. This commit handled this exception by skipping the LB sg update. Change-Id: I21a4d6cb515633d47b534f180517687d07b8f83f Closes-bug: 1876666
openshift-ci-robot
added
the
approved
MaysaMacedo
changed the title
|
@MaysaMacedo: This pull request references Bugzilla bug 1838985, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-medium
|
/test verify |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luis5tb, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
@MaysaMacedo: All pull requests linked via external trackers have merged: openshift/kuryr-kubernetes#240. Bugzilla bug 1838985 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@MaysaMacedo: new pull request created: #242 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
luis5tb
changed the title
Kuryr: Fix OpenShift API loadbalancer
When a pod event is handled it's possible that a Network Policy and Service
are affected by that pod and the LB sg of selected services needs to be
updated. However, the endpoints for the matched service may not be yet
present or were deleted, resulting in a NotFound exception.
This commit handled this exception by skipping the LB sg update.
Change-Id: I21a4d6cb515633d47b534f180517687d07b8f83f
Closes-bug: 1876666