Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1840187:Ensure LB resources with ERROR status are deleted #245

Merged
merged 1 commit into from May 27, 2020
Merged

Bug 1840187:Ensure LB resources with ERROR status are deleted #245

merged 1 commit into from May 27, 2020

Conversation

MaysaMacedo
Copy link
Contributor

In case a LB resource ends up with ERROR in the provisioning status
we must ensure the deletion and recreation of the resource.

Closes-bug: 1879371
Change-Id: I2531948ab6181cfa5049b54c78935c23f60173d2

@MaysaMacedo
Ensure LB resources with ERROR status are deleted
245acd6 
In case a LB resource ends up with ERROR in the provisioning status
we must ensure the deletion and recreation of the resource.

Closes-bug: 1879371
Change-Id: I2531948ab6181cfa5049b54c78935c23f60173d2
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 26, 2020
@openshift-ci-robot
Copy link

@MaysaMacedo: This pull request references Bugzilla bug 1840187, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1840187:Ensure LB resources with ERROR status are deleted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@luis5tb
Copy link
Contributor

luis5tb commented May 27, 2020

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luis5tb, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MaysaMacedo,luis5tb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit 47bb3bd into openshift:master May 27, 2020
@openshift-ci-robot
Copy link

@MaysaMacedo: All pull requests linked via external trackers have merged: openshift/kuryr-kubernetes#245. Bugzilla bug 1840187 has been moved to the MODIFIED state.

In response to this:

Bug 1840187:Ensure LB resources with ERROR status are deleted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo
Copy link
Contributor Author

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@MaysaMacedo: #245 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	kuryr_kubernetes/controller/drivers/lbaasv2.py
M	kuryr_kubernetes/tests/unit/controller/drivers/test_lbaasv2.py
Falling back to patching base and 3-way merge...
Auto-merging kuryr_kubernetes/tests/unit/controller/drivers/test_lbaasv2.py
Auto-merging kuryr_kubernetes/controller/drivers/lbaasv2.py
CONFLICT (content): Merge conflict in kuryr_kubernetes/controller/drivers/lbaasv2.py
Patch failed at 0001 Ensure LB resources with ERROR status are deleted

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo MaysaMacedo mentioned this pull request May 27, 2020
Merged
@MaysaMacedo MaysaMacedo deleted the remove-lb-resources-on-error branch April 27, 2021 07:56
MaysaMacedo pushed a commit to MaysaMacedo/kuryr-kubernetes-1 that referenced this pull request Jul 1, 2021
@openshift-merge-robot
Merge pull request openshift#245 from danehans/proxy_reconciler
c7c18b7 
Adds Proxy Controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celebdor celebdor Awaiting requested review from celebdor

@dulek dulek Awaiting requested review from dulek

Assignees

@luis5tb luis5tb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MaysaMacedo @openshift-ci-robot @luis5tb @openshift-cherrypick-robot @openshift-merge-robot