Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1843784: Ensure security_groups on LBaaSLoadBalancer defaults to empty list #258

Merged
merged 1 commit into from Jun 4, 2020
Merged

[release-4.5] Bug 1843784: Ensure security_groups on LBaaSLoadBalancer defaults to empty list #258

merged 1 commit into from Jun 4, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #257

/assign luis5tb

@MaysaMacedo
Ensure security_groups on LBaaSLoadBalancer defaults to empty list
9742d09 
When no security groups is present on the LBaaSLoadBalancer oslo
versioned object it should default to an empty list and not to
None. Otherwise iterations of the security_groups field fails.

Closes-bug: 1881575

Change-Id: I9a98584f80219bf5c2ea414177826a26470d414f
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 4, 2020
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1843674 has been cloned as Bugzilla bug 1843784. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1843784: Ensure security_groups on LBaaSLoadBalancer defaults to empty list

In response to this:

[release-4.5] Bug 1843674: Ensure security_groups on LBaaSLoadBalancer defaults to empty list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1843674: Ensure security_groups on LBaaSLoadBalancer defaults to empty list [release-4.5] Bug 1843784: Ensure security_groups on LBaaSLoadBalancer defaults to empty list Jun 4, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jun 4, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1843784, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1843674 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1843674 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

[release-4.5] Bug 1843784: Ensure security_groups on LBaaSLoadBalancer defaults to empty list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 4, 2020
@luis5tb
Copy link
Contributor

luis5tb commented Jun 4, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luis5tb, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2020
@knobunc knobunc added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jun 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit d9f81d2 into openshift:release-4.5 Jun 4, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/kuryr-kubernetes#258. Bugzilla bug 1843784 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1843784: Ensure security_groups on LBaaSLoadBalancer defaults to empty list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb
Copy link
Contributor

luis5tb commented Jun 4, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 4, 2020
Merged
@openshift-cherrypick-robot
Copy link
Author

@luis5tb: new pull request created: #265

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MaysaMacedo pushed a commit to MaysaMacedo/kuryr-kubernetes-1 that referenced this pull request Jul 1, 2021
@openshift-merge-robot
Merge pull request openshift#258 from danwinship/ovn-gateway-mode
ecf1cc4 
ovn-kubernetes: fix gateway mode, log level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luis5tb luis5tb Awaiting requested review from luis5tb

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

Assignees

@luis5tb luis5tb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @luis5tb @knobunc @openshift-merge-robot @MaysaMacedo