Bug 1843342: Get RPM and Kuryr version from git #267
Conversation
openshift-ci-robot
added
the
approved
dulek
force-pushed
the
test-rpm-version
branch
8 times, most recently
from
3c26b42
to
dd625a0
Compare
dulek
changed the title
|
@dulek: This pull request references Bugzilla bug 1843342, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-low
|
/hold Still need to check if this helps with OCP builds too. |
openshift-ci-robot
added
the
do-not-merge/hold
dulek
force-pushed
the
test-rpm-version
branch
2 times, most recently
from
6621502
to
d796a9d
Compare
|
/hold cancel Alright, this should help. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/hold One more idea of an improvement. |
openshift-ci-robot
added
the
do-not-merge/hold
This commit makes sure we're getting the version to use as RPM and Python package semver from the last tag in git. This should solve issue of `kuryr-k8s-controller --version` returning 0.0.0 and remove the need to update versions in various places each time master gets opened to new release development. Change-Id: I5f2d56e1cdad6dace4c456ee7a6ff34f57a02b5d
|
/hold cancel Alright, that should work in OCP too, needed to double-check this. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test images Looks like job got stuck for some reason? |
|
@dulek: This pull request references Bugzilla bug 1843342. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dulek: This pull request references Bugzilla bug 1843342, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Aww, misclick, I'm not touching this again. :D |
|
@dulek: All pull requests linked via external trackers have merged: openshift/kuryr-kubernetes#267. Bugzilla bug 1843342 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.5 |
|
@dulek: #267 failed to apply on top of branch "release-4.5": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit makes sure we're getting the version to use as RPM and
Python package semver from the last tag in git. This should solve issue
of
kuryr-k8s-controller --versionreturning 0.0.0 and remove the needto update versions in various places each time master gets opened to new
release development.