Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1846452: Remove ovn-octavia provider tcp+udp limitation #279

Merged
merged 1 commit into from Jun 16, 2020
Merged

[release-4.5] Bug 1846452: Remove ovn-octavia provider tcp+udp limitation #279

merged 1 commit into from Jun 16, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #278

/assign luis5tb

@luis5tb
Remove ovn-octavia provider tcp+udp limitation
9e849d2 
ovn-octavia provider now can handle listeners on the same port
for both udp and tcp

Change-Id: I9d5e9bb9219c2d1eaca8ed43633bd41f428b2a4e
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 11, 2020
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1846396 has been cloned as Bugzilla bug 1846452. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1846452: Remove ovn-octavia provider tcp+udp limitation

In response to this:

[release-4.5] Bug 1846396: Remove ovn-octavia provider tcp+udp limitation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1846396: Remove ovn-octavia provider tcp+udp limitation [release-4.5] Bug 1846452: Remove ovn-octavia provider tcp+udp limitation Jun 11, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jun 11, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1846452, which is invalid:

  • expected dependent Bugzilla bug 1846396 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.5] Bug 1846452: Remove ovn-octavia provider tcp+udp limitation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 11, 2020
@luis5tb
Copy link
Contributor

luis5tb commented Jun 16, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@knobunc knobunc added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jun 16, 2020
@MaysaMacedo
Copy link
Contributor

/lgtm

1 similar comment
@gryf
Copy link
Member

gryf commented Jun 16, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gryf, luis5tb, MaysaMacedo, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MaysaMacedo,gryf,luis5tb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gryf, luis5tb, MaysaMacedo, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MaysaMacedo,gryf,luis5tb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@luis5tb
Copy link
Contributor

luis5tb commented Jun 16, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 16, 2020
@openshift-ci-robot
Copy link

@luis5tb: This pull request references Bugzilla bug 1846452, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1846396 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1846396 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 16, 2020
@luis5tb
Copy link
Contributor

luis5tb commented Jun 16, 2020

/test unit

@openshift-merge-robot openshift-merge-robot merged commit d31e8cb into openshift:release-4.5 Jun 16, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged: openshift/kuryr-kubernetes#279. The following pull requests linked via external trackers have not merged:

In response to this:

[release-4.5] Bug 1846452: Remove ovn-octavia provider tcp+udp limitation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb
Copy link
Contributor

luis5tb commented Jun 16, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 16, 2020
Merged
@openshift-cherrypick-robot
Copy link
Author

@luis5tb: new pull request created: #286

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 18, 2020
Merged
MaysaMacedo pushed a commit to MaysaMacedo/kuryr-kubernetes-1 that referenced this pull request Jul 1, 2021
@openshift-merge-robot
Merge pull request openshift#279 from alexanderConstantinescu/bugfix/…
a07454e 
…1737026

Bug 1737026: Making set internal to the statusManager and adding mutex for thread safety
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulek dulek Awaiting requested review from dulek

@gryf gryf Awaiting requested review from gryf

Assignees

@gryf gryf

@luis5tb luis5tb

@MaysaMacedo MaysaMacedo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @luis5tb @MaysaMacedo @gryf @knobunc @openshift-merge-robot