Rebase openshift/kuryr-kubernetes from https://opendev.org/openstack/kuryr-kubernetes #287
Conversation
Due to errors on the neutron side we might get a port on create_port request, with the binding_failed error and hence the port will not become active, leaving the pod in ContainerCreating state. We should instead delete the port and raise an error. Change-Id: I6e736b5c39f46fab78a538bab66089168fb69b54 Signed-off-by: Nayan Deshmukh <n.deshmukh@samsung.com>
ovn-octavia provider now can handle listeners on the same port for both udp and tcp Change-Id: I9d5e9bb9219c2d1eaca8ed43633bd41f428b2a4e
We've seen some issues related to the fact that on CNI DEL we wait for pod annotation to appear in CNI registry: 1. Overloaded kuryr-daemon HTTP server, because many stale DEL requests from CRI will saturate the number of free connections, causing CNI to answer requests extremely slowly. 2. Some CRI's will not delete network namespace before getting a successful CNI DEL. If we'll assign the same IP (or vlan) to a next pod, we might end up with an IP or vlan conflict and NetlinkError. This commit makes sure we only wait for VIFs up to 5 seconds on DEL requests, enough time for watcher to populate registry on restart. Also some code got moved around to make implementating the above simpler and some logs got clarified to make debugging of such issues easier later on. Change-Id: I9221b6bc9166597837a4b53382862aa6c6f3e94c Closes-Bug: 1882083 Related-Bug: 1854928
Upon kuryr-controller restart, if kuryr configuration regarding octavia provider has changed, the cleanup process not only removes the leftovers loadbalancers but also: - remove the lbs with the previous octavia provider driver - modifies endpoints annotations (provider information) to force the recreation of the loadbalancer with the new provider Change-Id: I78fd6bdd1f53ea8eb2ba85395fd2e3c651487c60
|
Hi @kuryr-bot. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-ok-to-test
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
|
/test images |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, kuryr-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
modify default failureThreshold for kuryr components
No description provided.