Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase openshift/kuryr-kubernetes from https://opendev.org/openstack/kuryr-kubernetes #313

Merged
merged 2 commits into from Jul 29, 2020
Merged

Rebase openshift/kuryr-kubernetes from https://opendev.org/openstack/kuryr-kubernetes #313

merged 2 commits into from Jul 29, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 29, 2020

No description provided.

dulek and others added 2 commits July 28, 2020 19:01
@dulek
Implement add_finalizer and remove_finalizer
b6c89de 
This commit adds helper client methods that will aid in working with
finalizers of the CRDs and other stuff. Also one place where we remove
the finalizer already is updated to use the methods.

Change-Id: I665e03f80102a08b2c3ec412a4417c3a32f9384b
Merge https://opendev.org/openstack/kuryr-kubernetes:master into master
ba009b7
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 29, 2020
@openshift-ci-robot
Copy link

Hi @kuryr-bot. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link
Contributor

dulek commented Jul 29, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, kuryr-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2020
@dulek
Copy link
Contributor

dulek commented Jul 29, 2020

/retest

Seems unrelated, fingers crossed.

@openshift-merge-robot openshift-merge-robot merged commit 4b68a15 into openshift:master Jul 29, 2020
MaysaMacedo pushed a commit to MaysaMacedo/kuryr-kubernetes-1 that referenced this pull request Jul 1, 2021
@openshift-merge-robot
Merge pull request openshift#313 from pecameron/sdn353
23fd50f 
Bug 1748162: Shift ovn db ports to 9000-9999 range
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gryf gryf Awaiting requested review from gryf

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

Assignees

@dulek dulek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@openshift-ci-robot @dulek @openshift-merge-robot