Merge with opendev repository. #391
Merged
+47
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like there are options to set default values for several parameters in requests session. This commit attempts to leverage that by globally setting certificates, SSL verification, token header and timeout. Change-Id: Ieecc14cef94f1678a935f23affa6ca37e3de4a91
In our client, for OpenStack client, we created a workaround for missing bulk port create (at that time). Turns out, that running out of the OpenStack resources, there could be SDKException thrown, which is fine, although due to the mistake, message wasn't informative at all. This patch is fixing this. Closes-Bug: 1901666 Change-Id: Iba0744840231088018ec37cb6e3d98e1df6916fa
Repeated rules are being created for the service while not needed, but on the downside it cause increased number of calls to the Neutron. In this patch we're being polite to Neutron by not creating them. Closes-Bug: 1888407 Change-Id: I4e64fb00666f0d8ebcb757d77b5cbc81bd69f9d3
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gryf, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MaysaMacedo
pushed a commit
to MaysaMacedo/kuryr-kubernetes-1
that referenced
this pull request
Jul 1, 2021
Autodetect OVN octavia provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.