Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1896696: Ensure leftover loadbalancer is cleaned up #411

Merged

Conversation

MaysaMacedo
Copy link
Contributor

@MaysaMacedo MaysaMacedo commented Nov 20, 2020

The openstacksdk version used (0.17.2) does
not support tags for loadbalancer. However, the
Octavia API does and the loadbalancers are
created with a tag. This commit ensures the
loadbalancer can be also filtered with tags
allowing the needed loadbalancers to get cleaned
up.

@openshift-ci-robot
Copy link

@MaysaMacedo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Ensure LBaaSLoadBalancer object is created for lb clean up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2020
@MaysaMacedo
Copy link
Contributor Author

/hold

Let's merge this when the other fixes needed for the lb clean up are also handled.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2020
@MaysaMacedo MaysaMacedo changed the title Ensure LBaaSLoadBalancer object is created for lb clean up Ensure leftover loadbalancer is cleaned up Nov 30, 2020
@openshift-ci-robot
Copy link

@MaysaMacedo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Ensure leftover loadbalancer is cleaned up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2020
@MaysaMacedo MaysaMacedo changed the title Ensure leftover loadbalancer is cleaned up Bug 1896696: Ensure leftover loadbalancer is cleaned up Dec 1, 2020
@openshift-ci-robot
Copy link

@MaysaMacedo: This pull request references Bugzilla bug 1896696, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1896696: Ensure leftover loadbalancer is cleaned up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 1, 2020
The openstacksdk version used (0.17.2) does
not support tags for loadbalancer. However, the
Octavia API does and the loadbalancers are
created with a tag. This commit ensures the
loadbalancer can be also filtered with tags
allowing the needed loadbalancers to get cleaned
up.

Change-Id: I62b0ae41a90bd2e0f72a56592cbd88fce3ad1a87
@openshift-ci-robot
Copy link

@MaysaMacedo: This pull request references Bugzilla bug 1896696, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1896696: Ensure leftover loadbalancer is cleaned up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

@MaysaMacedo: This pull request references Bugzilla bug 1896696, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (3.11.z) matches configured target release for branch (3.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1896696: Ensure leftover loadbalancer is cleaned up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@luis5tb
Copy link
Contributor

luis5tb commented Dec 2, 2020

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luis5tb, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MaysaMacedo,luis5tb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit c64e3d5 into openshift:release-3.11 Dec 2, 2020
@openshift-ci-robot
Copy link

@MaysaMacedo: All pull requests linked via external trackers have merged:

Bugzilla bug 1896696 has been moved to the MODIFIED state.

In response to this:

Bug 1896696: Ensure leftover loadbalancer is cleaned up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants