New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1896696: Ensure leftover loadbalancer is cleaned up #411
Bug 1896696: Ensure leftover loadbalancer is cleaned up #411
Conversation
@MaysaMacedo: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold Let's merge this when the other fixes needed for the lb clean up are also handled. |
431aff6
to
8ce7b3c
Compare
@MaysaMacedo: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
@MaysaMacedo: This pull request references Bugzilla bug 1896696, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The openstacksdk version used (0.17.2) does not support tags for loadbalancer. However, the Octavia API does and the loadbalancers are created with a tag. This commit ensures the loadbalancer can be also filtered with tags allowing the needed loadbalancers to get cleaned up. Change-Id: I62b0ae41a90bd2e0f72a56592cbd88fce3ad1a87
8ce7b3c
to
feb8900
Compare
@MaysaMacedo: This pull request references Bugzilla bug 1896696, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@MaysaMacedo: This pull request references Bugzilla bug 1896696, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luis5tb, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@MaysaMacedo: All pull requests linked via external trackers have merged: Bugzilla bug 1896696 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The openstacksdk version used (0.17.2) does
not support tags for loadbalancer. However, the
Octavia API does and the loadbalancers are
created with a tag. This commit ensures the
loadbalancer can be also filtered with tags
allowing the needed loadbalancers to get cleaned
up.