Bug 1929170: CNI: Protect from '' being passed as CNI_NETNS #456
Conversation
|
@dulek: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
Looks like we need to pin pip in kuryr-tester image to make sure we won't pull in a version incompatible with Python 2.7. This commit pins it to 20.3.3. Change-Id: I8f943bb1b834bcb89cb9da502f90ca8c84f3076f
dulek
force-pushed
the
fix-empty-cni-netns
branch
from
9ca53f8
to
7aa6dda
Compare
We've hit cases when openshift-node is passing empty string as CNI_NETNS in CNI requests. This is against the CNI spec and causes us to try to remove the host eth0 interface which fails hard. This commit makes sure we don't attempt to remove leftover container interfaces when '' is passed as CNI_NETNS. Change-Id: I457f68277103c77417a519ee03cf819e1e06d31c
dulek
force-pushed
the
fix-empty-cni-netns
branch
from
7aa6dda
to
7ed8283
Compare
dulek
changed the title
|
@dulek: This pull request references Bugzilla bug 1929170, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-urgent
|
/lgtm I wonder if the same could happen in 4.x |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dulek: All pull requests linked via external trackers have merged: Bugzilla bug 1929170 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It's possible we don't see it only because default node interface is named ens3 and kubelet hardcodes default container interface to eth0. |
…ide-integration Bug 1807072: Adds route-override-cni and whereabouts for secondary network routing and IPAM
We've hit cases when openshift-node is passing empty string as CNI_NETNS
in CNI requests. This is against the CNI spec and causes us to try to
remove the host eth0 interface which fails hard. This commit makes sure
we don't attempt to remove leftover container interfaces when '' is
passed as CNI_NETNS.